8000 (storage) Fix default host by JesseLovelace · Pull Request #7034 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

(storage) Fix default host #7034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JesseLovelace merged 1 commit into from
Dec 13, 2019
Merged

(storage) Fix default host #7034

JesseLovelace merged 1 commit into from
Dec 13, 2019

Conversation

@JesseLovelace
Copy link
Contributor
@JesseLovelace JesseLovelace commented Dec 12, 2019

Fixes #7004

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 12, 2019
frankyn
frankyn approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor
@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link
codecov bot commented Dec 13, 2019 •
edited
Loading

Codecov Report

Merging #7034 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7034   +/-   ##
=========================================
  Coverage     32.16%   32.16%           
- Complexity     3696     3702    +6     
=========================================
  Files           249      249           
  Lines         40369    40369           
  Branches       6134     6133    -1     
=========================================
  Hits          12984    12984           
  Misses        26315    26315           
  Partials       1070     1070
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/cloud/storage/StorageOptions.java 89.28% <100%> (ø) 10 <2> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06857f3...05783dc. Read the comment docs.

@JesseLovelace JesseLovelace merged commit afe98d2 into master Dec 13, 2019
@JesseLovelace JesseLovelace deleted the fixhost branch December 13, 2019 00:07
@BenWhitehead BenWhitehead mentioned this pull request Nov 10, 2021
Merged
BenWhitehead added a commit to googleapis/java-storage that referenced this pull request Nov 18, 2021
@BenWhitehead
fix: update StorageOptions to not overwrite any previously set host (#…
05375c0 
…1142)

When calling `StorageOptions#toBuilder()` after creating the builder the host was explicitly set to the default host. This change removes that behavior instead moving the setting of the default host to the instantiation of a new builder.

Add unit tests to ensure host is set to the expected values based on different ways of creating an instance of StorageOptions.

Related:
* googleapis/google-cloud-java#6579
* googleapis/google-cloud-java#7004
* googleapis/google-cloud-java#7034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Storage: MalformedURLException: no protocol

3 participants

@JesseLovelace @frankyn @googlebot
0