[Storage] Update default base host for google-cloud-storage #6579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6579 +/- ##
============================================
- Coverage 46.35% 46.35% -0.01%
Complexity 28001 28001
============================================
Files 2613 2613
Lines 288075 288075
Branches 33779 33779
============================================
- Hits 133526 133523 -3
- Misses 144309 144312 +3
Partials 10240 10240
Continue to review full report at Codecov.
|
JesseLovelace
approved these changes
Dec 3, 2019
crwilcox
approved these changes
Dec 3, 2019
This was referenced Dec 4, 2019
BenWhitehead
added a commit
to googleapis/java-storage
that referenced
this pull request
Nov 18, 2021
…1142) When calling `StorageOptions#toBuilder()` after creating the builder the host was explicitly set to the default host. This change removes that behavior instead moving the setting of the default host to the instantiation of a new builder. Add unit tests to ensure host is set to the expected values based on different ways of creating an instance of StorageOptions. Related: * googleapis/google-cloud-java#6579 * googleapis/google-cloud-java#7004 * googleapis/google-cloud-java#7034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating default endpoint prior to discovery document being updated for GCS libraries.
The change is updating the endpoint from:
https://www.googleapis.com/to the new endpoint for the JSON APIhttps://storage.googleapis.com/. The old endpoint will continue to work.This is a temporary change until the auto-generated client is updated when the discovery document is updated.
Foot note: Merge/Release week of Dec 3.