8000 Expose Object serialization for internal consumers by schmidt-sebastian · Pull Request #6085 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Expose Object serialization for internal consumers #6085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schmidt-sebastian merged 3 commits into from
Aug 23, 2019
Merged

Expose Object serialization for internal consumers #6085

schmidt-sebastian merged 3 commits into from
Aug 23, 2019

Conversation

@schmidt-sebastian
Copy link
Contributor
@schmidt-sebastian schmidt-sebastian commented Aug 15, 2019

This allows internal teams to create DocumentSnapshots from POJOs, Maps and the Proto.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 15, 2019
@codecov
Copy link
codecov bot commented Aug 21, 2019 •
edited
Loading

Codecov Report

Merging #6085 into master will decrease coverage by 7.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6085      +/-   ##
============================================
- Coverage     47.38%   40.35%   -7.04%     
+ Complexity    27182    25716    -1466     
============================================
  Files          2523     2524       +1     
  Lines        274581   220912   -53669     
  Branches      31380    24175    -7205     
============================================
- Hits         130123    89138   -40985     
+ Misses       134850   123333   -11517     
+ Partials       9608     8441    -1167
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/firestore/DocumentSnapshot.java 84.76% <0%> (-0.96%) 55 <2> (ø)
...main/java/com/google/cloud/firestore/Internal.java 0% <0%> (ø) 0 <0> (?)
...ud/devtools/containeranalysis/v1/GrafeasUtils.java 50% <0%> (-40.91%) 1% <0%> (ø)
...oogle/cloud/spanner/jdbc/JdbcDatabaseMetaData.java 61.9% <0%> (-22.97%) 145% <0%> (ø)
...afeas/src/main/java/io/grafeas/v1/GrafeasGrpc.java 48.32% <0%> (-18.89%) 30% <0%> (ø)
...om/google/cloud/http/BaseHttpServiceException.java 44.23% <0%> (-17.31%) 8% <0%> (ø)
...le/cloud/compute/v1/stub/HttpJsonNodeTypeStub.java 73.52% <0%> (-16.67%) 9% <0%> (-1%)
...le/cloud/compute/v1/stub/HttpJsonDiskTypeStub.java 73.52% <0%> (-16.67%) 9% <0%> (-1%)
...cloud/compute/v1/stub/HttpJsonMachineTypeStub.java 73.52% <0%> (-16.67%) 9% <0%> (-1%)
...google/cloud/compute/v1/stub/HttpJsonZoneStub.java 71.42% <0%> (-16.08%) 8% <0%> (-1%)
... and 1908 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1daf76a...0e78c19. Read the comment docs.

@chingor13 chingor13 requested a review from BenWhitehead August 21, 2019 19:01
@schmidt-sebastian
Copy link
Contributor Author
schmidt-sebastian commented Aug 22, 2019

@BenWhitehead Is there anything special I need to do regarding the formatting? I have re-installed my Maven dependencies and mvn com.coveo:fmt-maven-plugin:format doesn't show me a diff anymore, yet the verification still fails.

@schmidt-sebastian
Copy link
Contributor Author
schmidt-sebastian commented Aug 22, 2019

@BenWhitehead Is there anything special I need to do regarding the formatting? I have re-installed my Maven dependencies and mvn com.coveo:fmt-maven-plugin:format doesn't show me a diff anymore, yet the verification still fails.

To be clear, it did format the change the first time around.

@BenWhitehead
Copy link
Contributor
BenWhitehead commented Aug 22, 2019

@schmidt-sebastian The new file https://github.com/googleapis/google-cloud-java/pull/6085/files#diff-c1b66da3ed37700b15f5fb4c57e0328dR1 looks like it's missing a copyright header and that's why it's failing.

@BenWhitehead BenWhitehead mentioned this pull request Aug 22, 2019
Closed
@schmidt-sebastian
Copy link
Contributor Author
schmidt-sebastian commented Aug 22, 2019

Thanks :) It's passing now.

@BenWhitehead BenWhitehead mentioned this pull request Aug 22, 2019
Closed
@schmidt-sebastian schmidt-sebastian merged commit f58cce7 into master Aug 23, 2019
@kolea2 kolea2 mentioned this pull request Aug 28, 2019
Merged
@Neenu1995 Neenu1995 deleted the mrschmidt/serializer branch July 6, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BenWhitehead BenWhitehead

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schmidt-sebastian @BenWhitehead @googlebot
0