8000 Firestore:Fix make change in CustomClassMapper serialize and deserialize methods to public by abhinav-qlogic · Pull Request #5879 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Firestore:Fix make change in CustomClassMapper serialize and deserialize methods to public #5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abhinav-qlogic wants to merge 3 commits into from
Closed

Firestore:Fix make change in CustomClassMapper serialize and deserialize methods to public #5879

abhinav-qlogic wants to merge 3 commits into from

Conversation

@abhinav-qlogic
Copy link
@abhinav-qlogic abhinav-qlogic commented Jul 25, 2019

Fixes #5809

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2019
dmitry-s
dmitry-s reviewed Jul 25, 2019
View reviewed changes
Copy link
@dmitry-s dmitry-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
just wanted to point out that the class is currently package-private. It needs to be public so we can use it outside of the package. Otherwise looks good!

@codecov
Copy link
codecov bot commented Jul 26, 2019 •
edited
Loading

Codecov Report

Merging #5879 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5879      +/-   ##
============================================
- Coverage     46.79%   46.51%   -0.29%     
  Complexity    25648    25648              
============================================
  Files          2456     2456              
  Lines        267593   267477     -116     
  Branches      30564    29752     -812     
============================================
- Hits         125229   124408     -821     
+ Misses       133105   133026      -79     
- Partials       9259    10043     +784
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/firestore/CustomClassMapper.java 77.29% <0%> (ø) 102 <0> (ø) ⬇️
...va/com/google/cloud/compute/v1/InstanceClient.java 48.8% <0%> (-6.45%) 143% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java 47.9% <0%> (-5.99%) 43% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java 51.14% <0%> (-5.94%) 55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java 49.63% <0%> (-5.84%) 35% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java 50.41% <0%> (-5.79%) 31% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java 50% <0%> (-5.74%) 31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java 49.04% <0%> (-5.74%) 43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java 48.57% <0%> (-5.72%) 35% <0%> (ø)
.../google/cloud/compute/v1/SecurityPolicyClient.java 48.1% <0%> (-5.7%) 39% <0%> (ø)
... and 257 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e98c8e6...200927a. Read the comment docs.

@ajaaym ajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2019
@chingor13 chingor13 requested a review from BenWhitehead August 21, 2019 19:01
@BenWhitehead
Copy link
Contributor
BenWhitehead commented Aug 22, 2019

Superseded by #6085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWhitehead BenWhitehead Awaiting requested review from BenWhitehead

1 more reviewer

@dmitry-s dmitry-s dmitry-s left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make CustomClassMapper's serialization and deserialization methods public

7 participants

@abhinav-qlogic @BenWhitehead @dmitry-s @googlebot @ajaaym @pmakani @yoshi-kokoro
0