8000 [Bigtable] minor Javadoc clean up for ModifyColumnFamiliesRequest by rahulKQL · Pull Request #5568 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

[Bigtable] minor Javadoc clean up for ModifyColumnFamiliesRequest #5568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorbernstein2 merged 3 commits into from
Jun 27, 2019
Merged

[Bigtable] minor Javadoc clean up for ModifyColumnFamiliesRequest #5568

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4aacc01
To Test Bigtable CI failure
rahulKQL Jun 26, 2019
d55a695
Adding some formatting related changes
rahulKQL Jun 26, 2019
eb6dcde
Added {@link ...} in the Javadoc
rahulKQL Jun 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 5 additions & 31 deletions .../src/main/java/com/google/cloud/bigtable/admin/v2/models/ModifyColumnFamiliesRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,33 +42,18 @@ public static ModifyColumnFamiliesRequest of(String tableId) {
return new ModifyColumnFamiliesRequest(tableId);
}

/**
* Configures the tableId to execute the modifications
*
* @param tableId
*/
/** Configures the tableId to execute the modifications */
ModifyColumnFamiliesRequest(String tableId) {
Preconditions.checkNotNull(tableId);
this.tableId = tableId;
}

/**
* Configures the name of the new ColumnFamily to be created
*
* @param familyId
* @return
*/
/** Configures the name of the new {@link ColumnFamily} to be created */
public ModifyColumnFamiliesRequest addFamily(String familyId) {
return addFamily(familyId, GCRules.GCRULES.defaultRule());
}

/**
* Configures the name and GcRule of the new ColumnFamily to be created
*
* @param familyId
* @param gcRule
* @return
*/
/** Configures the name and {@link GCRule} of the new {@link ColumnFamily} to be created */
public ModifyColumnFamiliesRequest addFamily(String familyId, GCRule gcRule) {
Preconditions.checkNotNull(gcRule);
Modification.Builder modification = Modification.newBuilder().setId(familyId);
Expand All @@ -77,13 +62,7 @@ public ModifyColumnFamiliesRequest addFamily(String familyId, GCRule gcRule) {
return this;
}

/**
* Updates the GCRule of existing ColumnFamily
*
* @param familyId
* @param gcRule
* @return
*/
/** Updates the {@link GCRule} of existing {@link ColumnFamily} */
public ModifyColumnFamiliesRequest updateFamily(String familyId, GCRule gcRule) {
Preconditions.checkNotNull(gcRule);
Modification.Builder modification = Modification.newBuilder().setId(familyId);
Expand All @@ -92,12 +71,7 @@ public ModifyColumnFamiliesRequest updateFamily(String familyId, GCRule gcRule)
return this;
}

/**
* Drops the specified ColumnFamily
*
* @param familyId
* @return
*/
/** Drops the specified {@link ColumnFamily} */
public ModifyColumnFamiliesRequest dropFamily(String familyId) {
Modification.Builder modification = Modification.newBuilder().setId(familyId).setDrop(true);
modFamilyRequest.addModifications(modification.build());
Expand Down
0