[Bigtable] minor Javadoc clean up for ModifyColumnFamiliesRequest #5568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My local master is failing with some wired issue: ``` Caused by: org.apache.maven.enforcer.rule.api.EnforcerRuleException: Failed while enforcing RequireUpperBoundDeps. The error(s) are [ Require upper bound dependencies error for com.google.guava:guava:27.1-android paths to dependency are: ```
sduskis
reviewed
Jun 26, 2019
| * @param familyId | ||
| * @return | ||
| */ | ||
| /** Configures the name of the new ColumnFamily to be created */ |
Contributor
There was a problem hiding this comment.
Would it make sense to add {@link ColumnFamily}? (and the same applies for all of the other comments)
Author
There was a problem hiding this comment.
Yes, It makes sense to me as well. I have added {@link ...}.
Codecov Report
@@ Coverage Diff @@
## master #5568 +/- ##
=========================================
Coverage 46.72% 46.72%
- Complexity 24630 24645 +15
=========================================
Files 2351 2351
Lines 256175 256175
Branches 29324 29319 -5
=========================================
Hits 119686 119686
Misses 127569 127569
Partials 8920 8920
Continue to review full report at Codecov.
|
sduskis
approved these changes
Jun 26, 2019
This was referenced Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some undefined tags from
ModifyColumnFamiliesRequest.java