Change AckReplyConsumer to expose individual methods for replying #1899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
message outcome as opposed to use an enum.
|
Changes Unknown when pulling 6d6bff6 on davidtorres:remove-ack-reply-enum into ** on GoogleCloudPlatform:master**. |
pongad
previously requested changes
Apr 12, 2017
| * asynchronously pull messages from it. | ||
| */ | ||
| public class CreateSubscriptionAndPullMessages { | ||
| public class CreateSubscriptionAndConsumeMessages { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| private final LinkedBlockingQueue<AckReplyConsumer> outstandingMessageReplies = | ||
| new LinkedBlockingQueue<>(); | ||
| private AckReply ackReply = AckReply.ACK; | ||
| private boolean shouldAck = true; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
|
LGTM |
|
Changes Unknown when pulling 03f6abc on davidtorres:remove-ack-reply-enum into ** on GoogleCloudPlatform:master**. |
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
* tests: Ignore flaky tests in ITSinkTest * chore: generate libraries at Thu Dec 11 21:55:08 UTC 2025 --------- Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@garrettjonesgoogle PTAL
Note I have renamed one example file, I'm not sure if that will have unintended consequences (like in docs), please let me know.