8000 Replace consumer.accept by consumer.ack & consumer.nack in Pub/Sub · Issue #1864 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]

Skip to content

Replace consumer.accept by consumer.ack & consumer.nack in Pub/Sub #1864

@kir-titievsky

Description

@kir-titievsky

Attempting to tie together some offline discussion to get to a concrete resolution. The Pub/Sub ack ReplyConsumer [1] uses an enum for reply type. There seems to consensus that explicit .ack() and .nack() methods would be cleaner. Could we make this change before beta or disagree, @pongad @davidtorres @garrettjonesgoogle ?

[1] http://googlecloudplatform.github.io/google-cloud-java/0.11.1/apidocs/com/google/cloud/pubsub/spi/v1/AckReplyConsumer.html

Metadata

Metadata

Labels

api: pubsubIssues related to the Pub/Sub API.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0