8000 fix: added build and local testing command by kavinkumar807 · Pull Request #529 · google/adk-python · GitHub
[go: up one dir, main page]
Skip to content

fix: added build and local testing command #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

fix: added build and local testing command #529

wants to merge 15 commits into from

Conversation

kavinkumar807
Copy link
Contributor
@kavinkumar807 kavinkumar807 commented May 3, 2025 •
edited
Loading

This PR fixes #564

  • added virtual environmental creation guide for windows which will helpful for windows developers
  • added command to build the package
  • added command to install locating build package for testing

@kavinkumar807 kavinkumar807 changed the title fix readme pip install fix: readme pip install May 3, 2025
@kavinkumar807
Copy link
Contributor Author

@hangfei @boyangsvl Raised PR

@kavinkumar807
Copy link
Contributor Author

@hangfei @boyangsvl I see the pip install issue is fixed as part of #520. Therefore repurposing this PR for the lint changes and other readme updates.

@kavinkumar807 kavinkumar807 changed the title fix: readme pip install fix: added build and local testing command May 3, 2025
@kavinkumar807
Copy link
Contributor Author

I'm not sure why test cases are failing for readme changes

@kavinkumar807
Copy link
Contributor Author

@hangfei @boyangsvl Synced with latest changes

@kavinkumar807
Copy link
Contributor Author

@hangfei @boyangsvl Synced the branch

hangfei
hangfei reviewed May 6, 2025
View reviewed changes
hangfei
hangfei reviewed May 6, 2025
View reviewed changes
@kavinkumar807
Copy link
Contributor Author

@hangfei resolved and synced with changes with main

@kavinkumar807
Copy link
Contributor Author

@hangfei Synced the PR with main

@kavinkumar807
Copy link
Contributor Author

@hangfei @DeanChensj Synced the PR with main

@hangfei hangfei added the ready to pull for importing back to Google label May 8, 2025
copybara-service bot pushed a commit that referenced this pull request May 8, 2025
@kavinkumar807 @copybara-github
Copybara import of the project:
41564de 
--
5eabc6c by kavinkumarbaskar <kavinkumarbaskar@gmail.com>:

fix readme pip install

--
bb21018 by kavinkumarbaskar <kavinkumarbaskar@gmail.com>:

fix: added build and local testing command

--
aa1f230 by kavinkumarbaskar <kavinkumarbaskar@gmail.com>:

fix: added example

--
69b649d by kavinkumarbaskar <kavinkumarbaskar@gmail.com>:

fix: updated the windows command

--
bd52023 by kavinkumarbaskar <kavinkumarbaskar@gmail.com>:

fix: removed redundant code
COPYBARA_INTEGRATE_REVIEW=#529 from kavinkumar807:fix-readme-pip-install a49d82d
PiperOrigin-RevId: 756122021
@hangfei
Copy link
Collaborator
hangfei commented May 8, 2025

committed in 41564de

@hangfei hangfei closed this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangfei hangfei hangfei approved these changes

Assignees
No one assigned
Labels
ready to pull for importing back to Google
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build and local testing command in contributing.md
2 participants
@kavinkumar807 @hangfei
0