8000 fix: Fix install command for Zsh compatibility. by Imfuyuwei · Pull Request #520 · google/adk-python · GitHub
[go: up one dir, main page]
Skip to content

fix: Fix install command for Zsh compatibility. #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 4, 2025
Merged

fix: Fix install command for Zsh compatibility. #520

merged 11 commits into from
May 4, 2025

Conversation

Imfuyuwei
Copy link
Contributor

Fix install command for Zsh compatibility. Wrapped extras list in quotes to prevent Zsh from expanding it as a glob pattern.

@Imfuyuwei
Fix install command for Zsh compatibility. Wrapped extras list in quo…
8000 dffd5a6 
…tes to prevent Zsh from expanding it as a glob pattern.
@google-cla Google CLA
Copy link
google-cla bot commented May 3, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Imfuyuwei Imfuyuwei changed the title Fix install command for Zsh compatibility. fix: Fix install command for Zsh compatibility. May 3, 2025
@hangfei
Copy link
Collaborator
hangfei commented May 3, 2025

Could you fix the workflow errors? @Imfuyuwei

@hangfei hangfei self-requested a review May 3, 2025 14:45
This was referenced May 3, 2025
Closed
Closed
@Imfuyuwei
Copy link
Contributor Author
Imfuyuwei commented May 3, 2025 •
edited
Loading

Thank you Hangfei @hangfei. Is the next step that you add the label to decide whether to merge the PR? If so, I'll leave it to you :)

BTW, not sure why the unit test checks are failing.

@hangfei
Copy link
Collaborator
hangfei commented May 3, 2025 •
edited
Loading

Yes. I will merge later.

There is test failure on head and need to fix that first. (fix here: #538)

@hangfei hangfei requested a review from Jacksunwei May 4, 2025 05:49
Jacksunwei
Jacksunwei reviewed May 4, 2025
View reviewed changes
Jacksunwei
Jacksunwei approved these changes May 4, 2025
View reviewed changes
Copy link
Collaborator
@Jacksunwei Jacksunwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Yuwei!

@Jacksunwei Jacksunwei added the ready to pull for importing back to Google label May 4, 2025
copybara-service bot pushed a commit that referenced this pull request May 4, 2025
@Imfuyuwei @copybara-github
Copybara import of the project:
5824c89 
--
ec246ae by Yuwei Fu <fuyuweiwill@gmail.com>:

Fix install command for Zsh compatibility. Wrapped extras list in quotes to prevent Zsh from expanding it as a glob pattern.

COPYBARA_INTEGRATE_REVIEW=#520 from Imfuyuwei:main 6cd4ecc
PiperOrigin-RevId: 754625822
@hangfei hangfei merged commit fb3915d into google:main May 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacksunwei Jacksunwei Jacksunwei approved these changes

@hangfei hangfei hangfei approved these changes

Assignees
No one assigned
Labels
ready to pull for importing back to Google
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Imfuyuwei @hangfei @Jacksunwei
0