8000 add lower() and upper for py str feat:(#232) by wdq112 · Pull Request #233 · go-python/gpython · GitHub
[go: up one dir, main page]
Skip to content

add lower() and upper for py str feat:(#232) #233

New issue
Merged
merged 2 commits into from
Feb 26, 2024
Merged

add lower() and upper for py str feat:(#232) #233

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e18c13d
add lower() and upper for py str
wdq112 Feb 25, 2024
e40546f
add test for py str upper() and lower()
wdq112 Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add lower() and upper for py str
  • Loading branch information
@wdq112
wdq112 committed Feb 25, 2024
commit e18c13daa49a817320ea3f051deb6b09424b73b7
16 changes: 16 additions & 0 deletions py/string.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,14 @@ replaced.`)
return self.(String).LStrip(args)
}, 0, "lstrip(chars) -> replace chars from begining of string")

StringType.Dict["upper"] = MustNewMethod("upper", func(self Object, args Tuple, kwargs StringDict) (Object, error) {
return self.(String).Upper()
}, 0, "upper() -> a copy of the string converted to uppercase")

StringType.Dict["lower"] = MustNewMethod("lower", func(self Object, args Tuple, kwargs StringDict) (Object, error) {
return self.(String).Lower()
}, 0, "lower() -> a copy of the string converted to lowercase")

}

// Type of this object
Expand Down Expand Up @@ -739,6 +747,14 @@ func (s String) RStrip(args Tuple) (Object, error) {
return String(strings.TrimRightFunc(string(s), f)), nil
}

func (s String) Upper() (Object, error) {
return String(strings.ToUpper(string(s))), nil
}

func (s String) Lower() (Object, error) {
return String(strings.ToLower(string(s))), nil
}

// Check stringerface is satisfied
var (
_ richComparison = String("")
Expand Down
46 changes: 46 additions & 0 deletions py/string_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,3 +98,49 @@ func TestStringFind(t *testing.T) {
})
}
}

func TestStringUpper(t *testing.T) {
tests := []struct {
name string
s String
want Object
}{{
name: "abc",
s: String("abc"),
want: String("ABC")},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got, err := tt.s.Upper()
if err != nil {
t.Fatalf("Upper() error = %v", err)
}
if got.(String) != tt.want.(String) {
t.Fatalf("Upper() got = %v, want %v", got, tt.want)
}
})
}
}

func TestStringLower(t *testing.T) {
tests := []struct {
name string
s String
want 5E11 Object
}{{
name: "ABC",
s: String("ABC"),
want: String("abc")},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got, err := tt.s.Lower()
if err != nil {
t.Fatalf("Lower() error = %v", err)
}
if got.(String) != tt.want.(String) {
t.Fatalf("Lower() got = %v, want %v", got, tt.want)
}
})
}
}
0