10000 add lower() and upper for py str feat:(#232) by wdq112 · Pull Request #233 · go-python/gpython · GitHub
[go: up one dir, main page]
Skip to content

add lower() and upper for py str feat:(#232) #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2024
Merged

add lower() and upper for py str feat:(#232) #233

merged 2 commits into from
Feb 26, 2024

Conversation

wdq112
Copy link
Contributor
@wdq112 wdq112 commented Feb 25, 2024 •
edited by sbinet
Loading

add lower() and upper for py str

Updates #232

@wdq112 wdq112 changed the title add lower() and upper for py str add lower() and upper for py str feat:#232 Feb 25, 2024
@wdq112 wdq112 changed the title add lower() and upper for py str feat:#232 add lower() and upper for py str feat:(#232) Feb 25, 2024
@wdq112
Copy link
Contributor Author
wdq112 commented Feb 25, 2024

feat #232

sbinet
sbinet approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member
@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

thanks for the PR.

could you send another PR against go-python/license adding yourself to the AUTHORS and/or CONTRIBUTORS file(s) ?
then I'll merge this one in.

thanks again.

@codecov Codecov
Copy link
codecov bot commented Feb 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.47%. Comparing base (23c0aa2) to head (e40546f).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   75.45%   75.47%   +0.01%     
==========================================
  Files          79       79              
  Lines       13214    13222       +8     
==========================================
+ Hits         9971     9979       +8     
  Misses       2568     2568              
  Partials      675      675

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbinet
Copy link
Member
sbinet commented Feb 26, 2024 •
edited
Loading

perhaps also add a test for upper and lower in py/tests/string.py, after:
https://github.com/go-python/gpython/blob/23c0aa2/py/tests/string.py#L889...L898

(to appease the testing gods)

@sbinet
Copy link
Member
sbinet commented Feb 26, 2024

needs go-python/license#22

@sbinet sbinet mentioned this pull request Feb 26, 2024
Merged
@sbinet sbinet merged commit 149d52c into go-python:main Feb 26, 2024
@sbinet
Copy link
Member
sbinet commented Feb 26, 2024

Thanks a lot for this PR.

do you want to give the last leg of #232 (str.join) a try ? :}

@wdq112
Copy link
Contributor Author
wdq112 commented Feb 27, 2024

I'll try it when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbinet sbinet sbinet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wdq112 @sbinet
0