8000 Remove legacy template helper functions by wxiaoguang · Pull Request #34426 · go-gitea/gitea · GitHub
[go: up one dir, main page]
Skip to content

Remove legacy template helper functions #34426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2025
Merged

Remove legacy template helper functions #34426

merged 1 commit into from
May 11, 2025

Conversation

wxiaoguang
Copy link
Contributor

These functions have been marked as panicIfDevOrTesting since 1.23 (#32422)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 11, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 11, 2025
@wxiaoguang wxiaoguang added this to the 1.25.0 milestone May 11, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 11, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 11, 2025
@techknowlogick techknowlogick merged commit 4a98ab0 into go-gitea:main May 11, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the remove-util-func branch May 11, 2025 05:48
@metiftikci
Copy link
Member

should mark this as breaking?

@techknowlogick
Copy link
Member

should mark this as breaking?

Let me add that. As then we'll remember to make note of it in release notes.

@techknowlogick techknowlogick added type/refactoring Existing code has been cleaned up. There should be no new functionality. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! labels May 11, 2025
@wxiaoguang wxiaoguang removed the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label May 11, 2025
@wxiaoguang
Copy link
Contributor Author
wxiaoguang commented May 11, 2025 •
edited
Loading

should mark this as breaking?

No, I do not think so.

Instead, we should avoid mentioning unnecessary "breakings" in the changelog, to avoid confusing end users. Most of the changes are not that breaking to most end users.

Last time I have edited the 1.24 release changelog to clarify that most breakings won't affected end users, but my changes were reset by unknown editors & reasons.

@lunny
Copy link
Member
lunny commented May 11, 2025

should mark this as breaking?

No, I do not think so.

Instead, we should avoid mentioning unnecessary "breakings" in the changelog, to avoid confusing end users. Most of the changes are not that breaking to most end users.

Last time I have edited the 1.24 changelog to clarify that most breakings won't affected end users, but my changes were reset by unknown editors & reasons.

This is not a breaking change, but it should be mentioned in the changelog, as some users may have customized template files that reference these helper functions.

@wxiaoguang
Copy link
Contributor Author

Every stable release we made huge template changes.

image

zjjhot added a commit to zjjhot/gitea that referenced this pull request May 12, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d536882 
* giteaofficial/main:
  Add a webhook push test for dev branch (go-gitea#34421)
  [skip ci] Updated translations via Crowdin
  Fix bug webhook milestone is not right. (go-gitea#34419)
  Only git operations should update `last changed` of a repository (go-gitea#34388)
  When updating comment, if the content is the same, just return and not update the databse (go-gitea#34422)
  Remove legacy template helper functions (go-gitea#34426)
  Fix GetUsersByEmails (go-gitea#34423)
  [skip ci] Updated translations via Crowdin
  Fix a bug when uploading file via lfs ssh command (go-gitea#34408)
  Merge and tweak markup editor expander CSS (go-gitea#34409)
  Bump `@github/relative-time-element` to v4.4.8 (go-gitea#34413)
  Refactor commit message rendering and fix bugs (go-gitea#34412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @metiftikci @techknowlogick @lunny @GiteaBot
0