8000 When updating comment, if the content is the same, just return and not update the databse by lunny · Pull Request #34422 · go-gitea/gitea · GitHub
[go: up one dir, main page]
Skip to content

When updating comment, if the content is the same, just return and not update the databse #34422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 11, 2025
Merged

When updating comment, if the content is the same, just return and not update the databse #34422

merged 6 commits into from
May 11, 2025

Conversation

lunny
Copy link
Member
@lunny lunny commented May 10, 2025

Fix #34318

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 10, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels May 10, 2025
@lunny lunny force-pushed the lunny/update_comment_same_content branch from 65eff3c to b7c54e1 Compare May 10, 2025 19:00
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 11, 2025
@lunny lunny added this to the 1.25.0 milestone May 11, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 11, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 11, 2025
@lunny lunny enabled auto-merge (squash) May 11, 2025 18:37
@lunny lunny merged commit b07e039 into go-gitea:main May 11, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 11, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 12, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d536882 
* giteaofficial/main:
  Add a webhook push test for dev branch (go-gitea#34421)
  [skip ci] Updated translations via Crowdin
  Fix bug webhook milestone is not right. (go-gitea#34419)
  Only git operations should update `last changed` of a repository (go-gitea#34388)
  When updating comment, if the content is the same, just return and not update the databse (go-gitea#34422)
  Remove legacy template helper functions (go-gitea#34426)
  Fix GetUsersByEmails (go-gitea#34423)
  [skip ci] Updated translations via Crowdin
  Fix a bug when uploading file via lfs ssh command (go-gitea#34408)
  Merge and tweak markup editor expander CSS (go-gitea#34409)
  Bump `@github/relative-time-element` to v4.4.8 (go-gitea#34413)
  Refactor commit message rendering and fix bugs (go-gitea#34412)
@wxiaoguang wxiaoguang deleted the lunny/update_comment_same_content branch May 12, 2025 12:41
@crackedmind
Copy link

@lunny Do you plan backport this to 1.24 before release?

@lunny lunny added the backport/v1.24 This PR should be backported to Gitea 1.24 label May 14, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 14, 2025
@lunny @GiteaBot
When updating comment, if the content is the same, just return and no…
9d12469 
…t update the databse (go-gitea#34422)

Fix go-gitea#34318
@GiteaBot GiteaBot mentioned this pull request May 14, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 14, 2025
lunny added a commit that referenced this pull request May 15, 2025
@GiteaBot @lunny @wxiaoguang
When updating comment, if the content is the same, just return and no…
2bf2d00 
…t update the databse (#34422) (#34464)

Backport #34422 by @lunny

Fix #34318

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

Comment edit save without actual edit triggers Webhook sending
6 participants
@lunny @crackedmind @silverwind @wxiaoguang @delvh @GiteaBot
0