repository.ConfigScoped and worktree.Commit with empty CommitOptions #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfontan
approved these changes
May 24, 2020
cmiller01
added a commit
to cmiller01/go-git
that referenced
this pull request
Jul 26, 2022
* previously an example existed for working with `config.Config`, but changes in implementation made the example not usable. (see go-git#75) * this mostly puts back the original example with some modifications to make it work with current implementation
traidare
pushed a commit
to traidare/go-git
that referenced
this pull request
Oct 26, 2024
repository.ConfigScoped and worktree.Commit with empty CommitOptions
pjbgf
pushed a commit
to pjbgf/go-git
that referenced
this pull request
Dec 19, 2024
* previously an example existed for working with `config.Config`, but changes in implementation made the example not usable. (see go-git#75) * this mostly puts back the original example with some modifications to make it work with current implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows implements the tools to read git config files in the different scopes, local, global, and system.
It also allows to do
Repository.Commitwith an emptyCommitOptions, since the author and committer information is read from the global scope, or wherever is defined.The PRs were reverted due to the old implementation was mixing in the filesystem storer, files from billy's filesystems and os.Files. Also, the implementation didn't suit the final implementation details (see #23). Thanks @cap10morgan for your excellent work, but I did a poor work reviewing the design of it.
Reverts #20
Reverts #31
Closes #23
Fixes #19