examples: add config example back. Fixes #523 #557
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* previously an example existed for working with `config.Config`, but changes in implementation made the example not usable. (see go-git#75) * this mostly puts back the original example with some modifications to make it work with current implementation
|
Please add a config example. It lists in the README for the examples, but does not exist. |
Coming back to some of my open PRs! This is the config example, it's in the README now (like you mention: https://github.com/go-git/go-git/tree/master/_examples) but the config example is missing, this should put it back |
|
@cmiller01 do you mind rebasing your PR and reintroducing the link on |
|
Closing this - I will forward port the commit directly to v6-exp instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.Config, but changes in implementation made the example not usable. (see repository.ConfigScoped and worktree.Commit with empty CommitOptions #75)