E52E Add drupal 8 and above ignore file by mourad-zitouni · Pull Request #3914 · github/gitignore · GitHub
[go: up one dir, main page]

Skip to content

Add drupal 8 and above ignore file#3914

Closed
mourad-zitouni wants to merge 1 commit intogithub:mainfrom
mourad-zitouni:drupal8-and-above
Closed

Add drupal 8 and above ignore file#3914
mourad-zitouni wants to merge 1 commit intogithub:mainfrom
mourad-zitouni:drupal8-and-above

Conversation

@mourad-zitouni
Copy link

Reasons for making this change:
The existing file is compatible with drupal 7, this file is for later versions (8/9/10...)

The existing file is compatible with drupal 7, this file is for later versions (8/9/10...)
@bdougie
Copy link
Contributor
bdougie commented Dec 10, 2021

Thanks for the contribution, but we will need more context about this change. Please explain the reason for divergence in Drupal and why the existing file does not support Drupal 8.

@mourad-zitouni
Copy link
Author

In fact there have been changes in the folder structure of Drupal in version 8, also they introduced composer to manage dependencies and because of that Drupal core and contributed modules files (and all their dependencies) are no longer part of the repository (they are downloaded by composer).

@bdougie
Copy link
Contributor
bdougie commented Dec 11, 2021

I believe that is all covered in this PR #3386 which I will go ahead merge now.

@lpalgarvio
Copy link
Contributor
lpalgarvio commented Dec 12, 2021

I believe that is all covered in this PR #3386 which I will go ahead merge now.

correct, plus there are wrong paths here in this PR.
contributed modules, themes, etc go in [root]/sites/all/* or [root]/sites/[sitename]/* for drupal7
and [root]/* or [root]/sites/all/* or [root]/sites/[sitename]/* for drupal 8

@lpalgarvio
Copy link
Contributor
lpalgarvio commented Dec 12, 2021

I believe that is all covered in this PR #3386 which I will go ahead merge now.

correct, plus there are wrong paths here in this PR. contributed modules, themes, etc go in [root]/sites/all/* or [root]/sites/[sitename]/* for drupal7 and [root]/* or [root]/sites/all/* or [root]/sites/[sitename]/* for drupal 8

after all might need future review for paths, im seeing new references in some places. might be a drupal 8 or 9 change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0