Update Drupal.gitignore with upstream conventions: prefix /web for dr…#3386
Merged
bdougie merged 1 commit intogithub:mainfrom Dec 11, 2021
Merged
Conversation
…upal code; remove deprecated simpletest directory; allow project composer.json|lock at root; add /vendor, composer, robo, drush and drupal scripts to root
This was referenced Dec 11, 2021
Contributor
|
Merging this based on the assumption new Drupal users will be using Drupal 8 moving forward. If folks find this to break older workflows, I suggest they open a community PR for Drupal-legacy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Update
Drupal.gitignoretemplateDetails
Update Drupal.gitignore with upstream conventions:
These scripts are all part of project development cycles of Drupal and are all PHP based:
Not including JavaScript tools like Yarn, NPM, Gulp, Grunt, Bower or Ruby tools like SASS and Compass because although very popular and widely used, they are based on different programming languages and incur in much more complexity than adding a few paths and they are also alternatives to each others.
The rationale behind this is the move to officially support AND recommend Composer in Drupal projects: https://www.drupal.org/docs/develop/using-composer
Relevant links being:
This patch conforms and updates the outdated notions that were based on old Drupal 7 community standards and the provided Drupal 8 .gitignore for non-composer installs.
Drupal 8 still includes and maintains a .gitignore for simplified non-composer installs inside the tarball file, however this is since many years (since Drupal 6 times, back then recommending Drush, then later composer in late Drupal 7 cycle) the non-preferred method of using and deploying Drupal.