This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Fix opening links on enterprise instances. #1309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes opening links on enterprise instances. Previously we were comparing `repo.FullName == ActiveRepo.Name` which always failed as `repo.FullName` returns `owner/name` whereas `ActiveRepo.Name` just returns the `name` portion. Construct a full name for the active repo and check that. Fixes #1291
grokys
commented
Nov 9, 2017
| @@ -131,7 +131,8 @@ void RefreshRepo() | |||
| if (!isdotcom) | |||
| { | |||
| var repo = await SimpleApiClient.GetRepository(); | |||
| return (repo.FullName == ActiveRepo.Name || repo.Id == 0) && SimpleApiClient.IsEnterprise(); | |||
| var activeRepoFullName = ActiveRepo.Owner + '/' + ActiveRepo.Name; | |||
| return (repo.FullName == activeRepoFullName || repo.Id == 0) && SimpleApiClient.IsEnterprise(); | |||
There was a problem hiding this comment.
I'm not sure what the check for repo.Id == 0 is needed for here?
|
This LGTM 👍 . Thanks for the fix @grokys |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly compare repository full name.
Previously we were comparing
repo.FullName == ActiveRepo.Namewhich always failed asrepo.FullNamereturnsowner/namewhereasActiveRepo.Namejust returns thenameportion. Construct a full name for the active repo and check that.Fixes #1291