8000 No Open/Link to GitHub Available · Issue #1291 · github/VisualStudio · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

No Open/Link to GitHub Available #1291

Closed
ambroselittle opened this issue Nov 4, 2017 · 2 comments
Closed

No Open/Link to GitHub Available #1291

ambroselittle opened this issue Nov 4, 2017 · 2 comments
Labels
bug

Comments

@ambroselittle
Copy link
  • GitHub Extension for Visual Studio version: 2.3.4.54
  • Visual Studio version: 15.4.2

Repro:

  1. Open solution that is in a git repo from our GitHub Enterprise.
  2. Open any code (.cs) file (or .config, for instance).
  3. Right-click on any line to view the context menu.

Expected: See a GitHub -> menu that has an Open/Link to GitHub link that will take me to the corresponding line in the repo/branch that I'm on at the time.

Actual: No GitHub menu.

Notes: I reported this to Phil Haack and he looped in Andreia Gaita on Twitter. She suggested I report this here.

Will email logs.
@shana shana added the bug label Nov 7, 2017
@grokys
Copy link
Contributor
grokys commented Nov 9, 2017

Hi @ambroselittle,

Apologies for the delay. I've just tried this and indeed we seem to have a bug with Open/Link to GitHub on Enterprise instances.

The problem is at this line: repo.FullName returns the repo name in the form owner/name and it's being compared with ActiveRepo.Name which returns just the repro name.

Sorry about that - we'll get a fix in for the next release!

grokys added a commit that referenced this issue Nov 9, 2017
@grokys
Correctly compare repository full name.
e714452 
Fixes opening links on enterprise instances.

Previously we were comparing `repo.FullName == ActiveRepo.Name` which always failed as `repo.FullName` returns `owner/name` whereas `ActiveRepo.Name` just returns the `name` portion. Construct a full name for the active repo and check that.

Fixes #1291
@grokys grokys mentioned this issue Nov 9, 2017
Merged
@ambroselittle
Copy link
Author

Awesome. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shana @grokys @ambroselittle
0