8000 Master PR for refactoring connections by grokys · Pull Request #1277 · github/VisualStudio · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Master PR for refactoring connections #1277

Merged
merged 43 commits into from
Nov 21, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
b790d96
ILoginCache -> IKeychain
grokys Aug 25, 2017
1c81104
Use IKeychain for credentials.
grokys Aug 25, 2017
21f888e
Updated parameter name.
grokys Aug 25, 2017
7e061d1
Removed unneeded usings.
grokys Aug 25, 2017
c8b8dd7
Updated variable names.
grokys Aug 25, 2017
95f2c0b
Remove `IObservableKeychainAdapter`.
grokys Aug 25, 2017
7b4080f
Merge branch 'master' into fixes/1176-duplicate-login-classes
grokys Aug 30, 2017
3b13736
Store "master" credential.
grokys Aug 30, 2017
a142423
Merge branch 'master' into fixes/1176-duplicate-login-classes
grokys Sep 7, 2017
bcfbd79
Fix broken merge.
grokys Sep 7, 2017
c52a261
Merge branch 'fixes/1176-duplicate-login-classes' into fixes/harden-c…
grokys Sep 7, 2017
e6c5d89
Merge branch 'master' into fixes/1176-duplicate-login-classes
grokys Oct 20, 2017
17c845e
Merge branch 'fixes/1176-duplicate-login-classes' into fixes/harden-c…
grokys Oct 20, 2017
a627271
Merge branch 'master' into refactor/connections-master
grokys Oct 20, 2017
470ea13
Removed `IConnection.Repositories`.
grokys Oct 20, 2017
d98ec51
Refactored ConnectionManager/Connection.
grokys Oct 23, 2017
aa78f03
Refactored RepositoryHost(s).
grokys Oct 23, 2017
7cf89c9
Added DebuggerDisplay back in.
grokys Oct 23, 2017
213a7fc
Moved LocalRepositories to GitHub.VisualStudio.
grokys Oct 24, 2017
90c35c5
Track login metrics.
grokys Oct 26, 2017
9db05a7
Fix failing tests.
grokys Oct 26, 2017
f854b79
WIP: Removing RepositoryHost(s)
grokys Oct 26, 2017
3240372
WIP: Still removing RepositoryHost(s)
grokys Oct 26, 2017
038f232
WIP: Removing RepositoryHost(s) from tests.
grokys Oct 26, 2017
a57a759
Finished migrating tests (I think).
grokys Oct 27, 2017
95cd0b1
Added IModelServiceFactory implemenation.
grokys Oct 27, 2017
6034643
Added IGlobalConnection.
grokys Oct 27, 2017
17aebf8
Removed ConnectionManager.ConnectionCreated.
grokys Oct 27, 2017
00232f0
Merge branch 'master' into refactor/connections-master
grokys Nov 3, 2017
01aad33
Merge branch 'refactor/connections-master' into refactor/connections/…
grokys Nov 3, 2017
217e415
Merge branch 'refactor/connections/local-repositories' into refactor/…
grokys Nov 3, 2017
7e57621
Insert AccountCacheItem for connection.
grokys Nov 7, 2017
e45d0c6
Merge branch 'master' into refactor/connections-master
grokys Nov 7, 2017
8f6d218
Merge branch 'refactor/connections-master' into refactor/connections/…
grokys Nov 7, 2017
32f073a
Merge branch 'refactor/connections/local-repositories' into refactor/…
grokys Nov 7, 2017
9f15db6
Merge branch 'refactor/connection-manager' into refactor/connections/…
grokys Nov 7, 2017
cd546bb
Fix CA errors.
grokys Nov 7, 2017
def6070
Merge pull request #1283 from github/refactor/connections/remove-repo…
grokys Nov 8, 2017
fc57163
Merge branch 'master' into refactor/connections-master
grokys Nov 8, 2017
d9c2a2f
Removed empty file.
grokys Nov 8, 2017
cefd4b9
Merge branch 'master' into refactor/connections-master
grokys Nov 14, 2017
7d7b188
Merge branch 'master' into refactor/connections-master
grokys Nov 20, 2017
4701dd0
Merge branch 'master' into refactor/connections-master
grokys Nov 20, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP: Removing RepositoryHost(s)
  • Loading branch information
grokys committed Oct 26, 2017
commit f854b79087a99cc631f8f245acb0f08330d79b7a
10 changes: 3 additions & 7 deletions src/GitHub.App/Controllers/UIController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ internal enum Trigger

readonly IUIFactory factory;
readonly IGitHubServiceProvider gitHubServiceProvider;
readonly IRepositoryHosts hosts;
readonly IConnectionManager connectionManager;

readonly CompositeDisposable disposables = new CompositeDisposable();
Expand Down Expand Up @@ -140,25 +139,22 @@ internal enum Trigger

public UIController(IGitHubServiceProvider serviceProvider)
: this(serviceProvider,
serviceProvider.TryGetService<IRepositoryHosts>(),
serviceProvider.TryGetService<IUIFactory>(),
serviceProvider.TryGetService<IConnectionManager>())
{
Guard.ArgumentNotNull(serviceProvider, nameof(serviceProvider));
}

public UIController(IGitHubServiceProvider gitHubServiceProvider,
IRepositoryHosts hosts, IUIFactory factory,
IUIFactory factory,
IConnectionManager connectionManager)
{
Guard.ArgumentNotNull(gitHubServiceProvider, nameof(gitHubServiceProvider));
Guard.ArgumentNotNull(hosts, nameof(hosts));
Guard.ArgumentNotNull(factory, nameof(factory));
Guard.ArgumentNotNull(connectionManager, nameof(connectionManager));

this.factory = factory;
this.gitHubServiceProvider = gitHubServiceProvider;
this.hosts = hosts;
this.connectionManager = connectionManager;

#if DEBUG
Expand Down Expand Up @@ -220,7 +216,7 @@ public void Start()
else // sanity check: it makes zero sense to pass a connection in when calling the auth flow
Debug.Assert(false, "Calling the auth flow with a connection makes no sense!");

hosts.EnsureInitialized().ToObservable()
connectionManager.GetLoadedConnections().ToObservable()
.ObserveOn(RxApp.MainThreadScheduler)
.Subscribe(_ => { }, () =>
{
Expand All @@ -231,7 +227,7 @@ public void Start()
else
{
connectionManager
.GetLoggedInConnections(hosts)
.GetLoggedInConnections()
.FirstOrDefaultAsync()
.Select(c =>
{
Expand Down
37 changes: 0 additions & 37 deletions src/GitHub.App/Factories/RepositoryHostFactory.cs

This file was deleted.

4 changes: 0 additions & 4 deletions src/GitHub.App/GitHub.App.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,6 @@
<Compile Include="Info\GitHubUrls.cs" />
<Compile Include="Infrastructure\ExportWrappers.cs" />
<Compile Include="Models\Account.cs" />
<Compile Include="Models\DisconnectedRepositoryHosts.cs" />
<Compile Include="Models\RepositoryHost.cs" />
<Compile Include="Models\RepositoryHosts.cs" />
<Compile Include="Models\RemoteRepositoryModel.cs" />
<Compile Include="SampleData\SampleViewModels.cs" />
<Compile Include="Api\ApiClient.cs" />
A8CD Expand All @@ -209,7 +206,6 @@
<Compile Include="UserErrors\PrivateRepositoryQuotaExceededUserError.cs" />
<Compile Include="ViewModels\PanePageViewModelBase.cs" />
<Compile Include="ViewModels\DialogViewModelBase.cs" />
<Compile Include="Models\ConnectionRepositoryHostMap.cs" />
<Compile Include="ViewModels\GistCreationViewModel.cs" />
<Compile Include="ViewModels\NotAGitRepositoryViewModel.cs" />
<Compile Include="ViewModels\NotAGitHubRepositoryViewModel.cs" />
Expand Down
34 changes: 0 additions & 34 deletions src/GitHub.App/Models/ConnectionRepositoryHostMap.cs

This file was deleted.

52 changes: 0 additions & 52 deletions src/GitHub.App/Models/DisconnectedRepositoryHosts.cs

This file was deleted.

39 changes: 0 additions & 39 deletions src/GitHub.App/Models/RepositoryHost.cs

This file was deleted.

Loading
0