Insert AccountCacheItem for connection.

When creating a `ModelService`, ensure that the correct `AccountCacheItem` is inserted.
github · jcansdale · Nov 21, 2017 · Aug 25, 2017 · Aug 25, 2017 · Aug 25, 2017
commit 7e57621d56ec6489a38b4e11d3843ef4cf1d1e7c
diff --git a/src/GitHub.App/Factories/ModelServiceFactory.cs b/src/GitHub.App/Factories/ModelServiceFactory.cs
@@ -3,6 +3,7 @@
 using System.ComponentModel.Composition;
 using System.Threading;
 using System.Threading.Tasks;
+using GitHub.Caches;
 using GitHub.Models;
 using GitHub.Services;
 using Microsoft.VisualStudio.Shell;
@@ -44,6 +45,8 @@ public async Task<IModelService> CreateAsync(IConnection connection)
                         await apiClientFactory.Create(connection.HostAddress),
                         await hostCacheFactory.Create(connection.HostAddress),
                         avatarProvider);
+                    result.InsertUser(AccountCacheItem.Create(connection.User));
+                    cache.Add(connection, result);
                 }
             }
             finally

diff --git a/src/UnitTests/GitHub.App/Factories/ModelServiceFactoryTests.cs b/src/UnitTests/GitHub.App/Factories/ModelServiceFactoryTests.cs
@@ -0,0 +1,85 @@
+using System;
+using System.Threading.Tasks;
+using GitHub.Caches;
+using GitHub.Extensions;
+using GitHub.Factories;
+using GitHub.Models;
+using GitHub.Primitives;
+using GitHub.Services;
+using NSubstitute;
+using Xunit;
+
+namespace UnitTests.GitHub.App.Factories
+{
+    public class ModelServiceFactoryTests : TestBaseClass
+    {
+        public class TheCreateAsyncMethod
+        {
+            [Fact]
+            public async Task ShouldCreateDifferentModelServiceForDifferentHost()
+            {
+                var target = CreateTarget();
+                var instance1 = await target.CreateAsync(CreateConnection("https://github.com"));
+                var instance2 = await target.CreateAsync(CreateConnection("https://another.com"));
+
+                Assert.NotSame(instance1, instance2);
+            }
+
+            [Fact]
+            public async Task ShouldCreateDifferentModelServiceForDifferentConnectionsWithSameAddress()
+            {
+                var target = CreateTarget();
+                var instance1 = await target.CreateAsync(CreateConnection("https://github.com"));
+                var instance2 = await target.CreateAsync(CreateConnection("https://github.com"));
+
+                Assert.NotSame(instance1, instance2);
+            }
+
+            [Fact]
+            public async Task ShouldCacheModelServiceForHost()
+            {
+                var target = CreateTarget();
+                var connection = CreateConnection("https://github.com");
+                var instance1 = await target.CreateAsync(connection);
+                var instance2 = await target.CreateAsync(connection);
+
+                Assert.Same(instance1, instance2);
+            }
+
+            [Fact]
+            public async Task ShouldInsertUser()
+            {
+                var hostCacheFactory = Substitute.For<IHostCacheFactory>();
+                var target = CreateTarget(hostCacheFactory: hostCacheFactory);
+                var connection = CreateConnection("https://github.com");
+                var hostCache = await hostCacheFactory.Create(connection.HostAddress);
+                var modelService = await target.CreateAsync(connection);
+
+                hostCache.Received().Insert("GitHub.Caches.AccountCacheItem___user", Arg.Any<byte[]>());
+            }
+        }
+
+        static ModelServiceFactory CreateTarget(
+            IHostCacheFactory hostCacheFactory = null)
+        {
+            var apiClientFactory = Substitute.For<IApiClientFactory>();
+            var avatarProvider = Substitute.For<IAvatarProvider>();
+
+            hostCacheFactory = hostCacheFactory ?? Substitute.For<IHostCacheFactory>();
+
+            return new ModelServiceFactory(
+                apiClientFactory,
+                hostCacheFactory,
+                avatarProvider);
+        }
+
+        static IConnection CreateConnection(string address, string login = "user")
+        {
+            var result = Substitute.For<IConnection>();
+            var user = CreateOctokitUser(login, address);
+            result.HostAddress.Returns(HostAddress.Create(address));
+                result.User.Returns(user);
+            return result;
+        }
+    }
+}
diff --git a/src/UnitTests/UnitTests.csproj b/src/UnitTests/UnitTests.csproj
@@ -223,6 +223,7 @@
     <Compile Include="GitHub.Api\SimpleApiClientTests.cs" />
     <Compile Include="GitHub.App\Caches\ImageCacheTests.cs" />
     <Compile Include="GitHub.App\Controllers\UIProviderTests.cs" />
+    <Compile Include="GitHub.App\Factories\ModelServiceFactoryTests.cs" />
     <Compile Include="GitHub.App\Models\AccountModelTests.cs" />
     <Compile Include="GitHub.App\Models\ModelServiceTests.cs" />
     <Compile Include="GitHub.App\Controllers\UIControllerTests.cs" />