This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Remove duplicate credential classes. #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously credentials were read by 4 separate interfaces/classes: - `IKeychain`/`WindowsKeychain` - `ILoginCache`/`LoginCache` - `SimpleCredentialStore` - `CredentialCache` Make everything go via `IKeychain`.
b357025 to
7e061d1
Compare
grokys
commented
Aug 25, 2017
| return new SecureUsernamePasswordCredentials | ||
| try | ||
| { | ||
| var credentials = ThreadHelper.JoinableTaskFactory.Run(async () => await keychain.Load(host)); |
There was a problem hiding this comment.
Previously we were doing a .Wait on an observable here, which is Bad. I've changed it to use the pattern described in the 3 Threading Rules of VS.
There was a problem hiding this comment.
Oh yeah, nice catch, we should beat whoever wrote that with a large 🐟
Just call `ToObservable` on the task returned by `IKeychain`.
Conflicts: src/GitHub.App/Models/RepositoryHost.cs src/UnitTests/GitHub.App/Models/RepositoryHostTests.cs
Merged
5 tasks
shana
approved these changes
Oct 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously credentials were read by 4 separate interfaces/classes:
GitHub.Api.ILoginCache/IWindowsLoginCacheGitHub.Api.ILoginCache/GitHub.Caches.LoginCacheSimpleCredentialStoreCredentialCacheThis PR consolidates all of these separate classes into
IKeychain/WindowsKeychain.Fixes #1176