8000 Duplicate ILoginCaches. · Issue #1176 · github/VisualStudio · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Duplicate ILoginCaches. #1176

Closed
grokys opened this issue Aug 21, 2017 · 2 comments
Closed

Duplicate ILoginCaches. #1176

grokys opened this issue Aug 21, 2017 · 2 comments
Labels
task

Comments

@grokys
Copy link
Contributor
grokys commented Aug 21, 2017

Pull request #845 introduced a new ILoginCache that uses Tasks instead of IObservables. However the PR didn't remove the existing ILoginCache.

The old ILoginCache should be removed.
@grokys grokys added the task label Aug 21, 2017
@grokys
Copy link
Contributor Author
grokys commented Aug 22, 2017

There are also https://github.com/github/VisualStudio/blob/master/src/GitHub.Api/WindowsLoginCache.cs and https://github.com/github/VisualStudio/blob/master/src/GitHub.Api/SimpleCredentialStore.cs which do the same thing.

@grokys grokys mentioned this issue Aug 25, 2017
Merged
@grokys
Copy link
Contributor Author
grokys commented Nov 29, 2017

Fixed by #1200

@grokys grokys closed this as completed Nov 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grokys
0