8000 fix(tracing): Instrument cursors returned from MongoDB operations by AbhiPrasad · Pull Request #6412 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

fix(tracing): Instrument cursors returned from MongoDB operations #6412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(tracing): Instrument cursors returned from MongoDB operations #6412

wants to merge 1 commit into from

Conversation

AbhiPrasad
Copy link
Member

Remaking #6337. Made a new PR since the old one seems to have caching issues.

Fixes #4495

Instrumented Cursors returned from certain MongoDB operations, this also resolves the problem mentioned in #5278.

@AbhiPrasad AbhiPrasad requested review from onurtemizkan, a team, mydea and lforst and removed request for a team December 5, 2022 12:53
@AbhiPrasad AbhiPrasad mentioned this pull request Dec 5, 2022
Closed
@github-actions
Copy link
Contributor
github-actions bot commented Dec 5, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.6 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.69 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.37 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.26 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.13 KB (0%)
@sentry/browser - Webpack (minified) 65.83 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.16 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.01 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.44 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.87 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.7 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.21 KB (0%)

@AbhiPrasad AbhiPrasad force-pushed the abhi-onur-mongodb-tracing-cursors branch 4 times, most recently from b12162c to 191164f Compare December 6, 2022 10:24
@AbhiPrasad AbhiPrasad force-pushed the abhi-onur-mongodb-tracing-cursors branch from 191164f to b43fbe1 Compare December 6, 2022 10:54
@AbhiPrasad
Copy link
Member Author

Ok the commit here just might be totally broken, since it;s the same ember tests that keep failing. @onurtemizkan do you mind remaking the whole PR and creating a brand new commit? 3rd times a charm!

@onurtemizkan
Copy link
Collaborator

Hmm yes, the problem might be the line:

import { EventEmitter } from 'events';

Opening another PR that compares the instance against an EventEmitter-like type we define internally. 🤞

@onurtemizkan onurtemizkan mentioned this pull request Dec 6, 2022
Merged
@AbhiPrasad
Copy link
Member Author

Superceded by #6437

@AbhiPrasad AbhiPrasad closed this Dec 6, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-onur-mongodb-tracing-cursors branch December 6, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onurtemizkan onurtemizkan onurtemizkan approved these changes

@mydea mydea Awaiting requested review from mydea mydea was automatically assigned from getsentry/team-web-sdk-frontend

@lforst lforst Awaiting requested review from lforst lforst was automatically assigned from getsentry/team-web-sdk-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MongoDB Integration: find method not measured correctly.
2 participants
@AbhiPrasad @onurtemizkan
0