10000 fix(tracing): Instrument cursors returned from MongoDB operations. by onurtemizkan · Pull Request #6337 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

fix(tracing): Instrument cursors returned from MongoDB operations. #6337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix(tracing): Instrument cursors returned from MongoDB operations. #6337

wants to merge 2 commits into from

Conversation

onurtemizkan
Copy link
Collaborator

Fixes #4495

Instrumented Cursors returned from certain MongoDB operations, this also resolves the problem mentioned in #5278.

10000
@onurtemizkan onurtemizkan changed the title fix(tracing): Handle cursors returned from MongoDB operations. fix(tracing): Instrument cursors returned from MongoDB operations. Nov 29, 2022
@github-actions
Copy link
Contributor
github-actions bot commented Nov 29, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.6 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.69 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.37 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.26 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.13 KB (0%)
@sentry/browser - Webpack (minified) 65.83 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.16 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 46.96 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.44 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.87 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.74 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 37.23 KB (0%)

@AbhiPrasad AbhiPrasad mentioned this pull request Nov 30, 2022
Closed
@AbhiPrasad
Copy link
Member

Seems like this causes tests to fail 🤔. Wonder what's happening here.

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) December 1, 2022 17:01
@onurtemizkan onurtemizkan force-pushed the onur/mongodb-tracing-cursors branch from a939bfb to 7a6e986 Compare December 2, 2022 15:48
@AbhiPrasad AbhiPrasad mentioned this pull request Dec 5, 2022
Closed
@AbhiPrasad
Copy link
Member

Closing #6412 since these ember tests seems to be keep failing.

@AbhiPrasad AbhiPrasad closed this Dec 5, 2022
auto-merge was automatically disabled December 5, 2022 12:53

Pull request was closed

@AbhiPrasad AbhiPrasad deleted the onur/mongodb-tracing-cursors branch December 5, 2022 12:53
@onurtemizkan onurtemizkan mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MongoDB Integration: find method not measured correctly.
2 participants
@onurtemizkan @AbhiPrasad
0