8000 Hide Disabled Installation Actions for Tool Installations by ElectronicBlueberry · Pull Request #14474 · galaxyproject/galaxy · GitHub
[go: up one dir, main page]

Skip to content

Hide Disabled Installation Actions for Tool Installations #14474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 19, 2022

Conversation

ElectronicBlueberry
Copy link
Member
@ElectronicBlueberry ElectronicBlueberry commented Aug 18, 2022

closes #8716

image

Tests temporarily removed until vue-jest works with <script setup> vuejs/vue-jest#489

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:

License

< 8000 !-- '"` -->

@ElectronicBlueberry ElectronicBlueberry changed the title Hide Disabled Installation Actions Hide Disabled Installation Actions for Tool Installations Aug 18, 2022
@ElectronicBlueberry ElectronicBlueberry marked this pull request as ready for review August 18, 2022 13:24
@github-actions github-actions bot added this to the 22.09 milestone Aug 18, 2022
@dannon
Copy link
Member
dannon commented Aug 19, 2022

@ElectronicBlueberry This looks good to me. I think to address the 'double click accidental action' issue, we may still want to pursue #8716 (comment)

Actually, now, any action combination you might do would require you to interact with a modal on the second action, so I think that's a non-issue now.

@dannon dannon merged commit c5893d4 into galaxyproject:dev Aug 19, 2022
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove 'install/cancel installation' button morphing
3 participants
0