feat(client): handle css transitions in lessons #64712
Conversation
|
I am fine with having a single checkbox being tested in this way, I am not sure we would want to increase the time of the test too much using the other reason for trying with the fake timers was because if the checkbox is checked to start, which could maybe happen if one of the checkboxes is checkbox.checked = false;
const uncheckedBG = window.getComputedStyle(checkbox).backgroundColor; |
|
Unfortunately, and I keep forgetting this, but fake timers can't help us here. They don't modify how css transitions behave, so we do have to wait. What we can do is check for any change in the tested property. It should start changing almost immediately. That's already the case for these test and they are pretty fast.
Yes, that's still an issue. I didn't want to complicate things too much in this PR, but, now that transitions are happening, you can design more elaborate tests if need be. |
|
I would say, the lab can go like this, and now that the testing works, we can iterate later, and for this PR focus on reviewing everything else |
Checklist:
mainbranch of freeCodeCamp.This needs the latest curriculum helpers, but that PR can go in independently.
Closes #63678
Closes #64190, though @majestic-owl448 I've simplified the test to only check a single checkbox. If you'd rather keep testing them all, please modify this PR as you like.