8000 feat(curriculum): allow use of transition property in Feature Selection page by majestic-owl448 · Pull Request #64190 · freeCodeCamp/freeCodeCamp · GitHub
[go: up one dir, main page]
Skip to content

feat(curriculum): allow use of transition property in Feature Selection page #64190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
majestic-owl448 wants to merge 1 commit into from
Closed

feat(curriculum): allow use of transition property in Feature Selection page #64190

majestic-owl448 wants to merge 1 commit into from

Conversation

@majestic-owl448
Copy link
Contributor
@majestic-owl448 majestic-owl448 commented Nov 27, 2025

Checklist:

Closes #63678

If there are other projects affected we will find out looking at user reports, but this one seems the most hit, with this transition property should now be allowed. I have added it in the solution to check that it keeps being allowed.

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Nov 27, 2025
leputz
leputz reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor
@leputz leputz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here calling __helpers.retryingTest without awaiting will immediately return a promise, which is a truthy value and will lead to this line get passed. However assert.notEqual(checkedBG, uncheckedBG) is not taking its role to pass or fail the test. Correct me if I'm mistaken.

@majestic-owl448 majestic-owl448 marked this pull request as draft November 27, 2025 22:58
@github-actions

This comment was marked as outdated.

Sign in to view
@majestic-owl448 majestic-owl448 force-pushed the add-retryng-test-to-feature-selection-page branch from a2a70d6 to eeaaf01 Compare November 28, 2025 10:58
@majestic-owl448 majestic-owl448 added the rwd v9 cert This is for issues dealing with the Responsive Web Design V9 Certification. label Nov 28, 2025
@ojeytonwilliams ojeytonwilliams mentioned this pull request Dec 17, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@leputz leputz leputz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

rwd v9 cert This is for issues dealing with the Responsive Web Design V9 Certification. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

transition property not compatible with tests

2 participants

@majestic-owl448 @leputz
0