fix: fix wrong id type for data-channel. #924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh ... this is bad.. thanks for fixing it !! |
|
From here https://developer.mozilla.org/en-US/docs/Web/API/RTCDataChannel/id, id is an unsigned integer, but in order not to break the existing API, at the moment I think just needs to check all The platform's native code, make sure the id is of type int. |
davidliu
approved these changes
Apr 21, 2022
|
For me it was also the the wrong id on windows ie not only wrong type #907 but keeping this line commented out works. |
hieplee2997
pushed a commit
to hieplee2997/flutter-webrtc
that referenced
this pull request
Jun 2, 2022
* fix: fix wrong id type for data-channel. * chore: `run import_sorter:main --no-comments`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #923, close #910