8000 Fix type error in data channel event listener by 41y08h · Pull Request #914 · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]
Skip to content

Fix type error in data channel event listener #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix type error in data channel event listener #914

wants to merge 1 commit into from

Conversation

@41y08h
Copy link
@41y08h 41y08h commented Apr 13, 2022

Hey $reader,
I just noticed that when I successfully establish a peer connection, I get this error, and tracing it gives me the changes proposed.
The variable map[id] is not always a string and that gives the error.

E/flutter (21744): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: type 'int' is not a subtype of type 'String'
E/flutter (21744): #0      RTCDataChannelNative.eventListener
package:flutter_webrtc/…/native/rtc_data_channel_impl.dart:54
E/flutter (21744): #1      _rootRunUnary (dart:async/zone.dart:1436:47)
E/flutter (21744): #2      _CustomZone.runUnary (dart:async/zone.dart:1335:19)
E/flutter (21744): #3      _CustomZone.runUnaryGuarded (dart:async/zone.dart:1244:7)
E/flutter (21744): #4      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:341:11)
E/flutter (21744): #5      _DelayedData.perform (dart:async/stream_impl.dart:591:14)
E/flutter (21744): #6      _StreamImplEvents.handleNext (dart:async/stream_impl.dart:706:11)
E/flutter (21744): #7      _PendingEvents.schedule.<anonymous closure> (dart:async/stream_impl.dart:663:7)
E/flutter (21744): #8      _rootRun (dart:async/zone.dart:1420:47)
E/flutter (21744): #9      _CustomZone.run (dart:async/zone.dart:1328:19)
E/flutter (21744): #10     _CustomZone.runGuarded (dart:async/zone.dart:1236:7)
E/flutter (21744): #11     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1276:23)
E/flutter (21744): #12     _rootRun (dart:async/zone.dart:1428:13)
E/flutter (21744): #13     _CustomZone.run (dart:async/zone.dart:1328:19)
E/flutter (21744): #14     _CustomZone.runGuarded (dart:async/zone.dart:1236:7)
E/flutter (21744): #15     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1276:23)
E/flutter (21744): #16     _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
E/flutter (21744): #17     _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)

@ycherniavskyi
Copy link
Member
ycherniavskyi commented Apr 13, 2022 •
edited
Loading

It seems that this PR duplicate #912, and as pointed there, this issue must be resolved in the native part of the library.

@cloudwebrtc
Copy link
Member

id must be int or null, so use #924 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@41y08h @ycherniavskyi @cloudwebrtc
0