8000 BugFix: iOS audio ouptut switching when toggling mic by rajansurani · Pull Request #1285 · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]
Skip to content

BugFix: iOS audio ouptut switching when toggling mic #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2023
Merged

BugFix: iOS audio ouptut switching when toggling mic #1285

merged 1 commit into from
Mar 7, 2023

Conversation

rajansurani
Copy link
Contributor

This is a PR to fix for Issue #1284.

Choosing a AVAudioSessionModeVideoChat as mode while using PlayAndRecord solves the issue of audio being switched to earpiece once the mic is toggled on and vice-versa.

cloudwebrtc
cloudwebrtc approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member
@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cloudwebrtc cloudwebrtc merged commit 59f6d8d into flutter-webrtc:main Mar 7, 2023
@shivanshtalwar
Copy link

With this change it doesn't give option to choose earpiece it defaults to speaker on ios call-kit call 👎🏻

@rajansurani
Copy link
Contributor Author

@cloudwebrtc @shivanshtalwar I am trying an alternative solution which can solve these, by resetting the audio routing based on the last used state as well as looking if it use video communication or not.

Maybe add a forcefull over ride option as well.

Does these seems like good option to you?

duyjack added a commit to duyjack/flutter-webrtc that referenced this pull request Mar 22, 2023
@duyjack
Merge branch 'dev'
b901238 
* dev: (37 commits)
  release: 0.9.24.
  Update flutter_webrtc.podspec
  avaudiosession mode changed to AVAudioSessionModeVideoChat (flutter-webrtc#1285)
  fix: eventSink is null program crash (flutter-webrtc#1281)
  Fix: After the window is closed, the old source still exists (flutter-webrtc#1279)
  Code format and follow google C++ style (flutter-webrtc#1280)
  release: 0.9.23.
  update dll/so for windows and linux.
  release: 0.9.22.
  fix: Without any setActive for rtc session, libwebrtc manages the session counter by itself. (flutter-webrtc#1266)
  Fix/remove-rtp-sender-dispose (flutter-webrtc#1267)
  OCT update fix (flutter-webrtc#1262)
  fix video renderer issue for safari. (flutter-webrtc#1265)
  dart_webrtc update to 1.0.15.
  release: 0.9.21.
  more fix.
  bug fix for windows.
  Fixed frame capturer returning images with wrong colors (flutter-webrtc#1258)
  release: 0.9.20.
  feat: add getCapabilities/setCodecPreferences methods. (flutter-webrtc#1251)
  ...
@shivanshtalwar0
Copy link

@rajansurani on the dart side how can we override it?

@shivanshtalwar0 shivanshtalwar0 mentioned this pull request Apr 1, 2023
Closed
@rajansurani
Copy link
Contributor Author

@rajansurani on the dart side how can we override it?

Still haven't got a perfect solution for both cases but probably shaning the mode of audio session when changing with Helper.speakerPhone could be an option.

@UserJah UserJah mentioned this pull request May 4, 2023
Open
@fullflash
Copy link
fullflash commented Nov 13, 2023 •
edited
Loading

looks like this implementation has been removed
in the current source there is no mode AVAudioSessionModeVideoChat

so be aware of this change
now we need to set this mode
#1329 (comment)

daniel-g-favoreto-opl pushed a commit to daniel-g-favoreto-opl/flutter-webrtc that referenced this pull request Mar 24, 2025
@rajansurani @daniel-g-favoreto-opl
avaudiosession mode changed to AVAudioSessionModeVideoChat (flutter-w…
fd49c1c 
…ebrtc#1285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajansurani @shivanshtalwar @shivanshtalwar0 @fullflash @cloudwebrtc
0