8000 Code format and follow google C++ style by xiaowei-guan · Pull Request #1280 · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]
Skip to content

Code format and follow google C++ style #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2023
Merged

Code format and follow google C++ style #1280

merged 1 commit into from
Feb 24, 2023

Conversation

xiaowei-guan
Copy link
Collaborator
  1. Code format by format.sh
  2. Remove ; after a }
  3. Use reinterpret_cast<T*>(...) instead of C style cast.
  4. Use static_cast() instread of C style cast.

@xiaowei-guan
Code format and follow google C++ style
1c73b6c 
1.Code format by format.sh
2.Remove ; after a }
3.Use reinterpret_cast<T*>(...) instead of C style cast.
4.Use static_cast<T*>() instread of C style cast.
cloudwebrtc
cloudwebrtc approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member
@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cloudwebrtc cloudwebrtc merged commit 4e09e0a into flutter-webrtc:main Feb 24, 2023
duyjack added a commit to duyjack/flutter-webrtc that referenced this pull request Mar 22, 2023
@duyjack
Merge branch 'dev'
b901238 
* dev: (37 commits)
  release: 0.9.24.
  Update flutter_webrtc.podspec
  avaudiosession mode changed to AVAudioSessionModeVideoChat (flutter-webrtc#1285)
  fix: eventSink is null program crash (flutter-webrtc#1281)
  Fix: After the window is closed, the old source still exists (flutter-webrtc#1279)
  Code format and follow google C++ style (flutter-webrtc#1280)
  release: 0.9.23.
  update dll/so for windows and linux.
  release: 0.9.22.
  fix: Without any setActive for rtc session, libwebrtc manages the session counter by itself. (flutter-webrtc#1266)
  Fix/remove-rtp-sender-dispose (flutter-webrtc#1267)
  OCT update fix (flutter-webrtc#1262)
  fix video renderer issue for safari. (flutter-webrtc#1265)
  dart_webrtc update to 1.0.15.
  release: 0.9.21.
  more fix.
  bug fix for windows.
  Fixed frame capturer returning images with wrong colors (flutter-webrtc#1258)
  release: 0.9.20.
  feat: add getCapabilities/setCodecPreferences methods. (flutter-webrtc#1251)
  ...
daniel-g-favoreto-opl pushed a commit to daniel-g-favoreto-opl/flutter-webrtc that referenced this pull request Mar 24, 2025
@xiaowei-guan @daniel-g-favoreto-opl
Code format and follow google C++ style (flutter-webrtc#1280)
c06c765 
1.Code format by format.sh
2.Remove ; after a }
3.Use reinterpret_cast<T*>(...) instead of C style cast.
4.Use static_cast<T*>() instread of C style cast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaowei-guan @cloudwebrtc
0