added tests, ready for pr submit

flask-api · jacebrowning · Jul 20, 2016 · Jul 18, 2016 · Jul 18, 2016 · Jul 19, 2016
commit fb5e5bbc7170e12460470671f1ed26c4cebbf2d6
diff --git a/flask_api/tests/test_app.py b/flask_api/tests/test_app.py
@@ -1,6 +1,6 @@
 # coding: utf8
 from __future__ import unicode_literals
-from flask import abort, make_response, request
+from flask import abort, make_response, request, jsonify
 from flask_api.decorators import set_renderers
 from flask_api import exceptions, renderers, status, FlaskAPI
 import json
@@ -19,6 +19,30 @@ class JSONVersion2(renderers.JSONRenderer):
     media_type = 'application/json; api-version="2.0"'
 
 
+# This is being used to test issue #58, source is taken from flask apierrors doc page
+class InvalidUsage(Exception):
+    status_code = 400
+
+    def __init__(self, message, status_code=None, payload=None):
+        Exception.__init__(self)
+        self.message = message
+        if status_code is not None:
+            self.status_code = status_code
+        self.payload = payload
+
+    def to_dict(self):
+        rv = dict(self.payload or ())
+        rv['message'] = self.message
+        return rv
+
+
+@app.errorhandler(InvalidUsage)
+def handle_invalid_usage(error):
+    response = jsonify(error.to_dict())
+    response.status_code = error.status_code
+    return response
+
+
 @app.route('/set_status_and_headers/')
 def set_status_and_headers():
     headers = {'Location': 'http://example.com/456'}
@@ -43,6 +67,16 @@ def api_exception():
     raise exceptions.PermissionDenied()
 
 
+@app.route('/custom_exception/')
+def custom_exception():
+    raise InvalidUsage('Invalid usage test.', status_code=410)
+
+
+@app.route('/custom_exception_no_code/')
+def custom_exception_no_status_code():
+    raise InvalidUsage('Invalid usage test.')
+
+
 @app.route('/abort_view/')
 def abort_view():
     abort(status.HTTP_403_FORBIDDEN)
@@ -95,6 +129,18 @@ def test_api_exception(self):
             expected = '{"message": "You do not have permission to perform this action."}'
             self.assertEqual(response.get_data().decode('utf8'), expected)
 
+    def test_custom_exception(self):
+        with app.test_client() as client:
+            response = client.get('/custom_exception/')
+            self.assertEqual(response.status_code, status.HTTP_410_GONE)
+            self.assertEqual(response.content_type, 'application/json')
+
+    def test_custom_exception_default_code(self):
+        with app.test_client() as client:
+            response = client.get('/custom_exception_no_code/')
+            self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
+            self.assertEqual(response.content_type, 'application/json')
+
     def test_abort_view(self):
         with app.test_client() as client:
             response = client.get('/abort_view/')