fix for #58 #59
Merged
fix for #58 #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this will need a way to handle both Flask 0.10.x and 0.11.x. |
|
Sounds good, I'll make those changes shortly. |
| @@ -116,3 +123,7 @@ def create_url_adapter(self, request): | |||
| self.config['SERVER_NAME'], | |||
| script_name=self.config['APPLICATION_ROOT'] or '/', | |||
| url_scheme=self.config['PREFERRED_URL_SCHEME']) | |||
|
|
|||
| @staticmethod | |||
| def get_minor_version(): | |||
There was a problem hiding this comment.
I wonder if this function might make more sense to live in compat.py and be reworked to something like is_flask_0_10()?
There was a problem hiding this comment.
sure, can do that.
There was a problem hiding this comment.
Or is_flask_10 or is_flask_legacy. Whatever makes most sense to you.
|
i see the issue, WIP |
|
👍 Looks good to me. All set to merge? |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across the issue recently for #58 as well, and saw the change was relatively simple.
I added some tests in there as well to check the custom error handler was working okay, looks good on my end.