Support iOS 13 with offline persistence #2271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve test hack * Comment in test hack
Comment on lines
+4
to
+5
| - [fixed] Fixed an issue in the interaction with the Firestore Emulator that | ||
| caused requests with timestamps to fail. |
There was a problem hiding this comment.
I rewrote this slightly when I addressed the merge conflict (to add a missing "the").
cc @yuchenshi
wilhuff
approved these changes
Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a behavior change in iOS 13 that causes transaction to be aborted (https://bugs.webkit.org/show_bug.cgi?id=202705). As this is now common in Mobile Safari, we changed the transaction logic in Firestore to allow for retries. If a transaction is not committed successfully, it can now be retried.
This PR makes all non-unit tests transactions idempotent.
Fixes #2232