Idempotency: Address TODOs, add Changelog #2270
Conversation
packages/firestore/CHANGELOG.md
Outdated
| @@ -1,8 +1,15 @@ | |||
| # Unreleased | |||
| - [changed] Improved iOS 13 support by addressing a change in Mobile Safari | |||
There was a problem hiding this comment.
It's probably more important to tie this to observed user behavior and link to the details if someone is really curious.
Fixed a crash on iOS 13 that could happen if Firestore was used in a tab in the background (#2232).
There was a problem hiding this comment.
Updated to say:
"Fixed a crash on iOS 13 that occurred when persistence was enabled in a background tab."
This still points out that it is a persistence-only issue. As for linking to the original issue, we unfortunately don't do this in our public release notes (see https://firebase.google.com/support/release-notes/js), but I added it here in case someone uses our internal release notes.
There was a problem hiding this comment.
FWIW, we do link to issues in the iOS release notes (https://firebase.google.com/support/release-notes/ios) so there's definitely precedent for it. I think it would be helpful.
* Add transaction retries (#2250) * Marking SimpleDb calls as idempotent (#2251) * Mark mostly readonly calls as idempotent (#2252) * Fix test failure (#2256) * Make handleUserChange idempotent (#2257) * Temporarily disable CountingQueryEngine tests (#2258) * Improve test hack (#2259) * Improve test hack * Comment in test hack * Make getNewDocumentChanges() idempotent (#2255) * Add onCommitted listeners for transactions (#2265) * Fix build * Fix Lint * Make applyRemoteEvent idempotent (#2263) * Make notifyLocalViewChanges idempotent (#2268) * Make releaseQuery idempotent (#2266) * Mark acknowledgeBatch and rejectBatch idempotent (#2269) * idempotent `allocateQuery` and `notifyLocalViewChanges` (#2264) * Mark collectGarbage idempotent (#2267) * Idempotency: Address TODOs, add Changelog (#2270)
Address TODOs, add Changelog.
The only outstanding TODO is the clean up of the different modes we pass to runPersistence, but we should discuss offline if we want to clean up the unit tests first.