8000 Refactor PublishingPlugin by daymxn · Pull Request #4940 · firebase/firebase-android-sdk · GitHub
[go: up one dir, main page]
Skip to content

Refactor PublishingPlugin #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 3, 2023
Merged

Refactor PublishingPlugin #4940

merged 17 commits into from
May 3, 2023

Conversation

daymxn
Copy link
Member
@daymxn daymxn commented Apr 26, 2023 •
edited
Loading

Per b/279790953,

This fixes an issue that was preventing our release config generation from functioning. Refer to #4923 for additional context on the original change.

More specifically, this changes the output directory of our release report to be the root directory, as our CI expects it to be.

This also fixes the following bugs:

b/280323342 - Add a test to avoid this issue in the future
b/280322962 - Fix IDEA sync breaking Gradle tasks

Note: this shouldn't be merged until after the current release (M131), as to avoid issues.

@daymxn daymxn requested review from VinayGuthal and rlazo April 26, 2023 20:05
@daymxn daymxn self-assigned this Apr 26, 2023
@github-actions
Copy link
Contributor
github-actions bot commented Apr 26, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor
github-actions bot commented Apr 26, 2023 •
edited
Loading

buildSrc Test Results

27 tests   27 ✔️  1m 21s ⏱️
  5 suites    0 💤
  5 files      0 ❌

Results for commit 2c4324d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor
github-actions bot commented Apr 26, 2023 •
edited
Loading

Unit Test Results

   765 files  +   737     765 suites  +737   33m 39s ⏱️ + 32m 16s
4 866 tests +4 590  4 844 ✔️ +4 568  21 💤 +21  1 ❌ +1 
9 170 runs  +8 618  9 127 ✔️ +8 575  42 💤 +42  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 2c4324d. ± Comparison against base commit bad35ef.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Apr 26, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (bad35ef)Merge (a58d311)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-abt

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?13.8 kB? (?)
    apk (aggressive)?116 kB? (?)
    apk (release)?1.27 MB? (?)

  • firebase-annotations

    TypeBase (bad35ef)Merge (a58d311)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?9.46 kB? (?)

  • firebase-appcheck

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?36.7 kB? (?)
    apk (aggressive)?362 kB? (?)
    apk (release)?1.56 MB? (?)

  • firebase-appcheck-debug

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?11.1 kB? (?)
    apk (aggressive)?363 kB? (?)
    apk (release)?1.56 MB? (?)

  • firebase-appcheck-debug-testing

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?7.26 kB? (?)
    apk (aggressive)?365 kB? (?)
    apk (release)?1.60 MB? (?)

  • firebase-appcheck-interop

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?5.00 kB? (?)
    apk (aggressive)?312 kB? (?)
    apk (release)?931 kB? (?)

  • firebase-appcheck-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?5.98 kB? (?)
    apk (aggressive)?370 kB? (?)
    apk (release)?1.94 MB? (?)

  • firebase-appcheck-playintegrity

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?11.0 kB? (?)
    apk (aggressive)?365 kB? (?)
    apk (release)?1.57 MB? (?)

  • firebase-appcheck-safetynet

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?10.4 kB? (?)
    apk (aggressive)?364 kB? (?)
    apk (release)?1.57 MB? (?)

  • firebase-appdistribution

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?247 kB? (?)
    apk (aggressive)?905 kB? (?)
    apk (release)?2.64 MB? (?)

  • firebase-appdistribution-api

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?16.0 kB? (?)
    apk (aggressive)?112 kB? (?)
    apk (release)?1.27 MB? (?)

  • firebase-appdistribution-api-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?5.84 kB? (?)
    apk (aggressive)?124 kB? (?)
    apk (release)?1.65 MB? (?)

  • firebase-common

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?75.3 kB? (?)
    apk (aggressive)?112 kB? (?)
    apk (release)?1.26 MB? (?)

  • firebase-common-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?13.3 kB? (?)
    apk (aggressive)?123 kB? (?)
    apk (release)?1.64 MB? (?)

  • firebase-components

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?44.9 kB? (?)
    apk (aggressive)?23.3 kB? (?)
    apk (release)?596 kB? (?)

  • firebase-config

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?88.9 kB? (?)
    apk (aggressive)?151 kB? (?)
    apk (release)?1.32 MB? (?)

  • firebase-config-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?9.90 kB? (?)
    apk (aggressive)?160 kB? (?)
    apk (release)?1.71 MB? (?)

  • firebase-crashlytics

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?351 kB? (?)
    apk (aggressive)?247 kB? (?)
    apk (release)?1.48 MB? (?)

  • firebase-crashlytics-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?6.58 kB? (?)
    apk (aggressive)?255 kB? (?)
    apk (release)?1.86 MB? (?)

  • firebase-crashlytics-ndk

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?1.66 MB? (?)
    apk (aggressive / arm64-v8a)?1.41 MB? (?)
    apk (aggressive / armeabi-v7a)?890 kB? (?)
    apk (aggressive / x86)?1.40 MB? (?)
    apk (aggressive / x86_64)?1.46 MB? (?)
    apk (release / arm64-v8a)?2.64 MB? (?)
    apk (release / armeabi-v7a)?2.12 MB? (?)
    apk (release / x86)?2.62 MB? (?)
    apk (release / x86_64)?2.68 MB? (?)

  • firebase-database

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?488 kB? (?)
    apk (aggressive)?359 kB? (?)
    apk (release)?1.72 MB? (?)

  • firebase-database-collection

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?33.6 kB? (?)
    apk (aggressive)?312 kB? (?)
    apk (release)?942 kB? (?)

  • firebase-database-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?28.1 kB? (?)
    apk (aggressive)?367 kB? (?)
    apk (release)?2.11 MB? (?)

  • firebase-datatransport

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)

  • firebase-decoders-json

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?7.67 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?15.3 kB? (?)

  • firebase-dynamic-links

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?54.6 kB? (?)
    apk (aggressive)?360 kB? (?)
    apk (release)?1.56 MB? (?)

  • firebase-dynamic-links-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?8.29 kB? (?)
    apk (aggressive)?368 kB? (?)
    apk (release)?1.94 MB? (?)

  • firebase-dynamic-module-support

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?5.67 kB? (?)
    apk (aggressive)?124 kB? (?)
    apk (release)?1.31 MB? (?)

  • firebase-encoders

    TypeBase (bad35ef)Merge (a58d311)Diff
    apk (aggressive)?8.68 kB? (?)
    apk (release)?15.3 kB? (?)

  • firebase-encoders-json

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?11.3 kB? (?)
    apk (aggressive)?24.0 kB? (?)
    apk (release)?596 kB? (?)

  • firebase-encoders-proto

    TypeBase (bad35ef)Merge (a58d311)Diff
    apk (aggressive)?8.86 kB? (?)
    apk (release)?21.7 kB? (?)

  • firebase-encoders-reflective

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?7.80 kB? (?)
    apk (aggressive)?9.06 kB? (?)
    apk (release)?22.5 kB? (?)

  • firebase-firestore

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?1.34 MB? (?)
    apk (aggressive)?518 kB? (?)
    apk (release)?3.94 MB? (?)

  • firebase-firestore-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?25.1 kB? (?)
    apk (aggressive)?526 kB? (?)
    apk (release)?4.33 MB? (?)

  • firebase-functions

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?45.3 kB? (?)
    apk (aggressive)?400 kB? (?)
    apk (release)?1.81 MB? (?)

  • firebase-functions-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?5.69 kB? (?)
    apk (aggressive)?408 kB? (?)
    apk (release)?2.19 MB? (?)

  • firebase-inappmessaging

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?452 kB? (?)
    apk (aggressive)?700 kB? (?)
    apk (release)?3.95 MB? (?)

  • firebase-inappmessaging-display

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?180 kB? (?)
    apk (aggressive)?1.53 MB? (?)
    apk (release)?5.21 MB? (?)

  • firebase-inappmessaging-display-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?17.6 kB? (?)
    apk (aggressive)?1.54 MB? (?)
    apk (release)?5.59 MB? (?)

  • firebase-inappmessaging-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?5.03 kB? (?)
    apk (aggressive)?708 kB? (?)
    apk (release)?4.33 MB? (?)

  • firebase-installations

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?55.2 kB? (?)
    apk (aggressive)?114 kB? (?)
    apk (release)?1.28 MB? (?)

  • firebase-installations-interop

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?8.05 kB? (?)
    apk (aggressive)?65.2 kB? (?)
    apk (release)?652 kB? (?)

  • firebase-installations-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?5.02 kB? (?)
    apk (aggressive)?127 kB? (?)
    apk (release)?1.67 MB? 8000 (?)

  • firebase-messaging

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?142 kB? (?)
    apk (aggressive)?465 kB? (?)
    apk (release)?1.72 MB? (?)

  • firebase-messaging-directboot

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?5.12 kB? (?)
    apk (aggressive)?465 kB? (?)
    apk (release)?1.72 MB? (?)

  • firebase-messaging-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?6.11 kB? (?)
    apk (aggressive)?472 kB? (?)
    apk (release)?2.10 MB? (?)

  • firebase-ml-modeldownloader

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?118 kB? (?)
    apk (aggressive)?168 kB? (?)
    apk (release)?1.41 MB? (?)

  • firebase-ml-modeldownloader-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?6.11 kB? (?)
    apk (aggressive)?176 kB? (?)
    apk (release)?1.79 MB? (?)

  • firebase-perf

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?315 kB? (?)
    apk (aggressive)?957 kB? (?)
    apk (release)?2.95 MB? (?)

  • firebase-perf-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?16.0 kB? (?)
    apk (aggressive)?965 kB? (?)
    apk (release)?3.34 MB? (?)

  • firebase-storage

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?115 kB? (?)
    apk (aggressive)?361 kB? (?)
    apk (release)?1.59 MB? (?)

  • firebase-storage-ktx

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?13.1 kB? (?)
    apk (aggressive)?369 kB? (?)
    apk (release)?1.97 MB? (?)

  • protolite-well-known-types

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?999 kB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?666 kB? (?)

  • transport-api

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?6.74 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?14.9 kB? (?)

  • transport-backend-cct

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?53.6 kB? (?)
    apk (aggressive)?57.6 kB? (?)
    apk (release)?105 kB? (?)

  • transport-runtime

    TypeBase (bad35ef)Merge (a58d311)Diff
    aar?180 kB? (?)
    apk (aggressive)?44.6 kB? (?)
    apk (release)?84.0 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9v96wgqxSL.html

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Apr 26, 2023 •
edited
Loading

Coverage Report 1

This report is too large (218,333 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/73IoCDM5h9.html

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Apr 26, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (a58d311) and the base commit (bad35ef) are not available.

No macrobenchmark data found for the base commit (bad35ef). Analysis for the CI merge commit (a58d311) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/G6qicdSKia/index.html

@rlazo
Copy link
Collaborator
rlazo commented Apr 26, 2023

Did you test this running the create release action?

@daymxn
Copy link
Member Author
daymxn commented May 1, 2023

Did you test this running the create release action?

Yup, no issues.

@daymxn daymxn merged commit fbbe403 into master May 3, 2023
@daymxn daymxn deleted the daymon-migrate-publishingplugin branch May 3, 2023 17:33
bswhite1 added a commit to bswhite1/firebase-android-sdk that referenced this pull request May 12, 2023
@bswhite1
Revert "Refactor PublishingPlugin (firebase#4940)"
4142a2f 
This reverts commit fbbe403.
@firebase firebase locked and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rlazo rlazo rlazo approved these changes

@VinayGuthal VinayGuthal Awaiting requested review from VinayGuthal

Assignees

@daymxn daymxn

Labels

no-changelog size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daymxn @google-oss-bot @rlazo
0