8000 Refactor PublishingPlugin by daymxn · Pull Request #4923 · firebase/firebase-android-sdk · GitHub
[go: up one dir, main page]
Skip to content

Refactor PublishingPlugin #4923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 26, 2023
Merged

Refactor PublishingPlugin #4923

merged 13 commits into from
Apr 26, 2023

Conversation

daymxn
Copy link
Member
@daymxn daymxn commented Apr 21, 2023

Per b/275739985,

This refactors the PublishingPlugin to follow more modernized practices, and is re-written in Kotlin. Everything added is accompanied with extensive documentation as well.

This PR also fixes the following bugs:

  • b/275754659 : All of the functionality from MultiProjectReleasePlugin has been migrated out and into the new PublishingPlugin
  • b/279212289 : The CheckHeadDependencies task has been moderately reduced
  • b/279212429 : Documentation is now provided for the CheckHeadDependencies task
  • b/279212325 : All release and publishing plugins + tasks have been migrated to a common directory

@daymxn daymxn requested a review from rlazo April 21, 2023 21:28
@daymxn daymxn self-assigned this Apr 21, 2023
@github-actions
Copy link
Contributor
github-actions bot commented Apr 21, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

1 similar comment
@github-actions
Copy link
Contributor
github-actions bot 8000 commented Apr 21, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor
github-actions bot commented Apr 21, 2023 •
edited
Loading

Unit Test Results

   776 files  +   538     776 suites  +538   30m 33s ⏱️ + 25m 54s
4 866 tests +3 491  4 756 ✔️ +3 485  21 💤 +  5  89 ❌ +1 
9 529 runs  +6 891  9 398 ✔️ +6 880  42 💤 +10  89 ❌ +1 

For more details on these failures, see this check.

Results for commit 963f378. ± Comparison against base commit 8171ac5.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Apr 21, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.21% (8171ac5) to 50.18% (ab4c824) by -0.03%.

    FilenameBase (8171ac5)Merge (ab4c824)Diff
    BooleanNode.java92.31%100.00%+7.69%
    ChildChangeAccumulator.java96.67%83.33%-13.33%

  • firebase-installations

    Overall coverage changed from ? (8171ac5) to 58.61% (ab4c824) by ?.

    22 individual files with coverage change

    FilenameBase (8171ac5)Merge (ab4c824)Diff
    AutoValue_InstallationResponse.java?58.93%?
    AutoValue_PersistedInstallationEntry.java?61.18%?
    AutoValue_TokenResult.java?45.65%?
    AwaitListener.java?0.00%?
    Clock.java?0.00%?
    CrossProcessLock.java?51.85%?
    FirebaseInstallations.java?96.62%?
    FirebaseInstallationServiceClient.java?4.80%?
    FirebaseInstallationsException.java?78.57%?
    FirebaseInstallationsRegistrar.java?100.00%?
    GetAuthTokenListener.java?100.00%?
    GetIdListener.java?70.00%?
    IidStore.java?22.39%?
    InstallationResponse.java?100.00%?
    PersistedInstallation.java?97.01%?
    PersistedInstallationEntry.java?100.00%?
    RandomFidGenerator.java?20.00%?
    RequestLimiter.java?100.00%?
    StateListener.java?0.00%?
    SystemClock.java?100.00%?
    TokenResult.java?100.00%?
    Utils.java?95.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Fpkk3aVEAU.html

@github-actions
Copy link
Contributor
github-actions bot commented Apr 24, 2023 •
edited
Loading

buildSrc Test Results

26 tests   26 ✔️  1m 36s ⏱️
  5 suites    0 💤
  5 files      0 ❌

Results for commit 963f378.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Apr 24, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (8171ac5) and merge commit (ab4c824).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EJEAu0w2Ms.html

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Apr 24, 2023 •
edited
Loading

Startup Time Report 1

The report is too large (117,074 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SdABJbpT8v/index.html

rlazo
rlazo reviewed Apr 25, 2023
View reviewed changes
@daymxn daymxn requested a review from rlazo April 25, 2023 18:07
rlazo
rlazo approved these changes Apr 25, 2023
View reviewed changes
@daymxn daymxn merged commit 0efc6c7 into master Apr 26, 2023
@daymxn daymxn deleted the daymon-migrate-publishingplugin branch April 26, 2023 16:49
VinayGuthal added a commit that referenced this pull request Apr 26, 2023
@VinayGuthal
Revert "Refactor PublishingPlugin (#4923)"
f54a8f1 
This reverts commit 0efc6c7.
@VinayGuthal VinayGuthal mentioned this pull request Apr 26, 2023
Merged
rlazo pushed a commit that referenced this pull request Apr 26, 2023
@VinayGuthal
Revert "Refactor PublishingPlugin (#4923)" (#4937)
90a9367 
This reverts commit 0efc6c7.
VinayGuthal added a commit that referenced this pull request Apr 26, 2023
@VinayGuthal
Revert "Revert "Refactor PublishingPlugin (#4923)" (#4937)"
18fd1e7 
This reverts commit 90a9367.
@daymxn daymxn mentioned this pull request Apr 26, 2023
Merged
VinayGuthal added a commit that referenced this pull request Apr 26, 2023
@VinayGuthal
Revert "Refactor PublishingPlugin (#4923)"
571aa76 
This reverts commit 0efc6c7.
VinayGuthal added a commit that referenced this pull request Apr 26, 2023
@VinayGuthal @maneesht
8A8E
Revert 4923 daymon migrate publishingplugin (#4945)
6d45825 
* Implement Android Executors for Storage (#4830)

* Revert "Refactor PublishingPlugin (#4923)" (#4937)

This reverts commit 0efc6c7.

* Revert "Refactor PublishingPlugin (#4923)"

This reverts commit 0efc6c7.

---------

Co-authored-by: Maneesh Tewani <maneesht@users.noreply.github.com>
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees

@daymxn daymxn

Labels
no-changelog size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daymxn @google-oss-bot @rlazo
0