8000 fix oauth session.destroy is undefined when use cookie-session package by fadiquader · Pull Request #2100 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

fix oauth session.destroy is undefined when use cookie-session package #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 2 commits into from
Nov 8, 2020
Merged

fix oauth session.destroy is undefined when use cookie-session package #2100

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b10609
fix oauth destroy session when use cookie-session
Oct 22, 2020
64d0987
fix destroy session for cookie-session
Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/authentication-oauth/src/express.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,14 @@ export default (options: OauthSetupSettings) => {
...payload
};

await new Promise((resolve, reject) =>
req.session.destroy(err => err ? reject(err) : resolve())
);
await new Promise((resolve, reject) => {
if (!req.session.destroy) {
req.session = null;
resolve();
}

req.session.destroy(err => err ? reject(err) : resolve());
});

debug(`Calling ${authService}.create authentication with strategy ${name}`);

Expand Down
0