8000 fix oauth session.destroy is undefined when use cookie-session package by fadiquader · Pull Request #2100 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

fix oauth session.destroy is undefined when use cookie-session package#2100

Merged
daffl merged 2 commits intofeathersjs:crowfrom
fadiquader:crow
Nov 8, 2020
Merged

fix oauth session.destroy is undefined when use cookie-session package#2100
daffl merged 2 commits intofeathersjs:crowfrom
fadiquader:crow

Conversation

@fadiquader
Copy link
Contributor
@fadiquader fadiquader commented Oct 22, 2020

Hi @daffl
Oauth in our project suddenly broke, and it turned out that we use cookie-session for OAuth like so

const cookieSession = require('cookie-session');

  app.configure(expressOauth({
    expressSession: cookieSession({
      name: 'session',
      keys: ['grant'],
      maxAge: 60 * 1000
    })
  }));

that fixes OAuth when scaling the app Kubernetes. So now when trying to authenticate, it throws an error because cookie-session doesn't have destroy.
The bug is in authentication-oauth repo.

Thank you.

@daffl
Copy link
Member
daffl commented Oct 25, 2020

Thanks. I didn't know that it is not always available. Wouldn't the promise just never resolve with this change though?

@fadiquader
Copy link
Contributor Author
fadiquader commented Oct 27, 2020

@daffl You're right! Updated the PR.
Thanks

@daffl daffl merged commit 46e84b8 into feathersjs:crow Nov 8, 2020
@daffl
Copy link
Member
daffl commented Nov 8, 2020

Cool, thanks again, will go out shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fadiquader @daffl
0