8000 __hooks become writable and configurable by bertho-zero · Pull Request #1520 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

__hooks become writable and configurable #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 2 commits into from
Oct 10, 2019
Merged

__hooks become writable and configurable #1520

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1431a70
__hooks become writable and configurable
bertho-zero Aug 22, 2019
2c757d2
Merge branch 'master' into bertho-zero-patch-1
daffl Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/commons/src/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,9 @@ export function enableHooks (obj: any, methods: string[], types: string[]) {

// Add non-enumerable `__hooks` property to the object
Object.defineProperty(obj, '__hooks', {
value: hookData
configurable: true,
value: hookData,
writable: true
});

return Object.assign(obj, {
Expand Down
0