__hooks become writable and configurable#1520
Merged
Conversation
We should be able to modify or delete this value. In a particular case it will avoid me this kind of error: ``` Uncaught TypeError: Cannot redefine property: __hooks ``` ``` Uncaught TypeError: Cannot delete property '__hooks' of #<Object> ```
Member
|
What would be the use case for this? It's usually not ideal having to modify undocumented framework internals in an application. For skipping hooks we can now e.g. use the adapter hook-less service methods. |
Contributor
Author
|
I wish I could edit or delete hooks, in my case I use uberproto to mixin a service in a const. This is not a normal use of Feathers but why protect these values? const Users = require('../services/users');
const service = Object.create(Users.prototype);
module.exports = service; // like a singleton ¯\_(ツ)_/¯
module.exports.init = () => {
const service = feathers()
.use( '/', new Users({ /* options */ }) )
.setup()
.service('/')
.hooks(hooks);
Proto.mixin(svc, service);
};This is not a choice but an imposed technical constraint. However, I do not have these errors anymore. |
Contributor
Author
|
This property just needs not to be enumerable. |
Member
Contributor
Author
|
It's actually in a test suite that it stuck, because of the init called several times. These are internal values but if we want to modify or delete them in cases of advanced or atypical use we should be able to do it. #1520 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be able to modify or delete this value.
In a particular case it will avoid me this kind of error: