8000 🌐 Update Korean translation for `docs/ko/docs/tutorial/first-steps.md`, `docs/ko/docs/tutorial/index.md`, `docs/ko/docs/tutorial/path-params.md`, and `docs/ko/docs/tutorial/query-params.md` by SnowSuno · Pull Request #4218 · fastapi/fastapi · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@SnowSuno
Copy link
Contributor

I found some translations that doesn't go well with the english docs.
ex)
But when you want to make a query parameter required, you can just not declare any default value:
그러나 쿼리 매개변수를 필수로 만들려면 기본값을 선언할 수 없습니다:
Which actually means:
그러나 쿼리 매개변수를 필수로 만들려면 단순히 기본값을 선언하지 않으면 됩니다:

I also smoothened some awkward translations to make it easier to understand.

Thank you always for your hard work.
related : #2017

@tiangolo tiangolo changed the title 🌐 Fix Korean translations 🌐 Fix Korean translation for docs/ko/docs/tutorial/first-steps.md Dec 8, 2021
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Dec 8, 2021
@github-actions github-actions bot mentioned this pull request Dec 8, 2021
Copy link
Contributor
@NinaHwang NinaHwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@codecov
Copy link
codecov bot commented Jun 14, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (34956d6) 100.00%.
Report is 1248 commits behind head on master.

❗ Current head 34956d6 differs from pull request most recent head 85f0d6d. Consider uploading reports for the commit 85f0d6d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #4218    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          540       532     -8     
  Lines        13969     13672   -297     
==========================================
- Hits         13969     13672   -297     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 34956d6 at: https://62a8480cab162c705ad73c97--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Fix Korean translation for docs/ko/docs/tutorial/first-steps.md 🌐 Update Korean translation for docs/ko/docs/tutorial/first-steps.md, docs/ko/docs/tutorial/index.md, docs/ko/docs/tutorial/path-params.md, and docs/ko/docs/tutorial/query-params.md Jun 26, 2023
@tiangolo
Copy link
Member

📝 Docs preview for commit 314a2d1 at: https://649a13c8b14d050fee045fd7--fastapi.netlify.app

@alejsdev
Copy link
Member
alejsdev commented Feb 2, 2024

Thanks for your contribution! @SnowSuno 🚀✨

And thanks for the help @NinaHwang 🤓

@alejsdev alejsdev merged commit d254e2f into fastapi:master Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-1 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0