This repository was archived by the owner on Apr 16, 2022. It is now read-only.
generate a warning message when backslashes in namespaces are not escaped properly #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 11, 2014
… are not escaped properly (xabbuh) This PR was merged into the 1.0-dev branch. Discussion ---------- generate a warning message when backslashes in namespaces are not escaped properly Running a build now procudes an output like this if backslashes are not escaped (see #11): ```text sphinx-build -b html -d _build/doctrees . _build/html Running Sphinx v1.1.3 loading pickled environment... done building [html]: targets for 1 source files that are out of date updating environment: 0 added, 1 changed, 0 removed reading sources... [100%] components/event_dispatcher/container_aware_dispatcher /var/www/Symfony/docs/components/event_dispatcher/container_aware_dispatcher.rst:10: WARNING: backslash not escaped in :class:`Symfony\\Component\EventDispatcher\\ContainerAwareEventDispatcher` /var/www/Symfony/docs/components/event_dispatcher/container_aware_dispatcher.rst:47: WARNING: backslash not escaped in :method:`Symfony\\Component\\EventDispatcher\ContainerAwareEventDispatcher::addListenerService` looking for now-outdated files... none found pickling environment... done checking consistency... done preparing documents... done writing output... [100%] index writing additional files... genindex search copying static files... done dumping search index... done dumping object inventory... done build succeeded, 2 warnings. Build finished. The HTML pages are in _build/html. ``` Commits ------- c0a4140 generate a warning message when backslashes in namespaces are not escaped properly 7455374 Merge pull request #13 from clemens-tolboom/feature/add-files-to-gitignore 4549925 Fixed for @stof feedback. 485dc69 Fixed for @stof feedback. b7e6032 Add files to .gitignore.
|
@xabbuh this is great. Can you update the submodule in the symfony-docs repo so that the Travis build benefits from this ? |
|
@stof Yes, I will do that later. I just noticed that we should also raise a warning if a backslash is not escaped in the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running a build now procudes an output like this if backslashes are not escaped (see #11):