8000 Add files to .gitignore. by clemens-tolboom · Pull Request #13 · fabpot/sphinx-php · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Apr 16, 2022. It is now read-only.

Add files to .gitignore. #13

Merged

Conversation

clemens-tolboom
Copy link
Contributor

Having trouble with git status about lingering _ext in symfony/symfony-docs#3918 @stof proposed to add those files to .gitignore in symfony/symfony-docs#3918 (comment)

I'm no python dev so not sure whether all files are ignorable.

@stof
Copy link
Contributor
stof commented Jun 8, 2014

The rule should be *.pyc. You don't want any of the compiled modules in the repo

@clemens-tolboom
Copy link
Contributor Author

Sorry for the bad commits ... I still have

symfony-docs$ git status
modified:   _exts (new commits)

but guess that's because I changes the _ext repo.

@stof
Copy link
Contributor
stof commented Jun 8, 2014

yes, indeed. Once this is merged, the symfony-docs repo will need to update the submodule to point to the new commit

@fabpot fabpot closed this Jun 8, 2014
@fabpot fabpot reopened this Jun 8, 2014
fabpot added a commit that referenced this pull request Jun 8, 2014
@fabpot fabpot merged commit 7455374 into fabpot:master Jun 8, 2014
@clemens-tolboom
Copy link
Contributor Author

Thanks for cherry picking as it was messy.

Should I squash next time?

@clemens-tolboom clemens-tolboom deleted the feature/add-files-to-gitignore branch June 9, 2014 13:00
@stof
Copy link
Contributor
stof commented Jun 9, 2014

@clemens-tolboom it is not necessary. @fabpot has a script automating it

@clemens-tolboom
Copy link
Contributor Author

:)

fabpot added a commit that referenced this pull request Jun 11, 2014
… are not escaped properly (xabbuh)

This PR was merged into the 1.0-dev branch.

Discussion
----------

generate a warning message when backslashes in namespaces are not escaped properly

Running a build now procudes an output like this if backslashes are not escaped (see #11):

```text
sphinx-build -b html -d _build/doctrees   . _build/html
Running Sphinx v1.1.3
loading pickled environment... done
building [html]: targets for 1 source files that are out of date
updating environment: 0 added, 1 changed, 0 removed
reading sources... [100%] components/event_dispatcher/container_aware_dispatcher
/var/www/Symfony/docs/components/event_dispatcher/container_aware_dispatcher.rst:10: WARNING: backslash not escaped in :class:`Symfony\\Component\EventDispatcher\\ContainerAwareEventDispatcher`
/var/www/Symfony/docs/components/event_dispatcher/container_aware_dispatcher.rst:47: WARNING: backslash not escaped in :method:`Symfony\\Component\\EventDispatcher\ContainerAwareEventDispatcher::addListenerService`
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] index
writing additional files... genindex search
copying static files... done
dumping search index... done
dumping object inventory... done
build succeeded, 2 warnings.

Build finished. The HTML pages are in _build/html.
```

Commits
-------

c0a4140 generate a warning message when backslashes in namespaces are not escaped properly
7455374 Merge pull request #13 from clemens-tolboom/feature/add-files-to-gitignore
4549925 Fixed for @stof feedback.
485dc69 Fixed for @stof feedback.
b7e6032 Add files to .gitignore.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0