some comment updates and fixes from @devyte's review

esp8266 · d-a-v · Aug 20, 2018 · Aug 8, 2018 · Aug 8, 2018 · Aug 9, 2018
commit cdba9b4751c45e704a8c3279d62d92d9f4bd543a
diff --git a/cores/esp8266/core_esp8266_app_entry_noextra4k.cpp b/cores/esp8266/core_esp8266_app_entry_noextra4k.cpp
@@ -10,7 +10,6 @@
 #include "cont.h"
 #include "coredecls.h"
 
-// callers to this function must *always* be inlined
 void disable_extra4k_at_link_time (void)
 {
     /*

diff --git a/cores/esp8266/core_esp8266_main.cpp b/cores/esp8266/core_esp8266_main.cpp
@@ -183,7 +183,7 @@ void init_done() {
 
    (note: setting app_entry() itself as "weak" is not sufficient and always
     ends up with the other "noextra4k" one linked, maybe because it has a
-    default value in linker scripts).
+    default ENTRY(app_entry) value in linker scripts).
 
    References:
    https://github.com/esp8266/Arduino/pull/4553

diff --git a/libraries/ESP8266WiFi/src/ESP8266WiFiSTA-WPS.cpp b/libraries/ESP8266WiFi/src/ESP8266WiFiSTA-WPS.cpp
@@ -28,6 +28,8 @@
 #include "ESP8266WiFiSTA.h"
 #include "coredecls.h" // disable_extra4k_at_link_time()
 
+static void wifi_wps_status_cb(wps_cb_status status);
+
 /**
  * WPS config
  * so far only WPS_TYPE_PBC is supported (SDK 1.2.0)
@@ -58,7 +60,7 @@ bool ESP8266WiFiSTAClass::beginWPSConfig(void) {
         return false;
     }
 
-    if(!wifi_set_wps_cb((wps_st_cb_t) &WPSStatusCB)) {
+    if(!wifi_set_wps_cb((wps_st_cb_t) &wifi_wps_status_cb)) {
         DEBUGV("wps cb failed\n");
         return false;
     }
@@ -78,7 +80,7 @@ bool ESP8266WiFiSTAClass::beginWPSConfig(void) {
  * WPS callback
  * @param status wps_cb_status
  */
-void ESP8266WiFiSTAClass::WPSStatusCB(wps_cb_status status) {
+void wifi_wps_status_cb(wps_cb_status status) {
     DEBUGV("wps cb status: %d\r\n", status);
     switch(status) {
         case WPS_CB_ST_SUCCESS:

diff --git a/libraries/ESP8266WiFi/src/ESP8266WiFiSTA.h b/libraries/ESP8266WiFi/src/ESP8266WiFiSTA.h
@@ -91,10 +91,6 @@ class ESP8266WiFiSTAClass {
     // ------------------------------------ STA remote configure  -----------------------------------
     // ----------------------------------------------------------------------------------------------
 
-    protected:
-
-        static void WPSStatusCB(wps_cb_status status);
-
     public:
 
         bool beginWPSConfig(void);