-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Automatic stack location selection (SYS or HEAP), enable per library AR-chive in arduino build system #5018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
1f88f28
60d3b4e
05b2aee
6ed54ee
6f7286e
12f412d
3259bbc
446220b
33db9a2
c64f994
cdba9b4
d38afda
67405c1
7c9d897
8ec3504
77b1b2d
28c9c22
eb18c5b
d08728a
8487455
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -100,7 +100,7 @@ class ESP8266WiFiSTAClass { | |
disable_extra4k_at_link_time(); // this call must always be inlined | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as far as i can tell this can never be inlined, unless we enable LTO? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have updated the code/comment (yet to push) as follow:
When it is not inlined, or not optimized by gcc, or if There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay, i finally understood why you were mentioning inlining in other comments and why you needed to make it inline. This is because Arduino IDE does not combine object files from libraries into static archives, it links them directly. This is in contrast with the core object files, which are first placed into an archive. However, recent Arduino versions support putting library object files into .a archive before linking, which should remove the need for inlining. Please check https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification and add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It works with Things are now more clear, thanks for this tip. I was not understanding in the first place why I had to use the inline trick and was wrongly thinking that objects files were stored in a library. I admit I don't often try to read the long-like-hell IDE commands. But I had to cheat and create an empty archive edit: now trying to find the arduino environment variable for the AR object |
||
return ::beginWPSConfig(); | ||
} | ||
|
||
bool beginSmartConfig(); | ||
bool stopSmartConfig(); | ||
bool smartConfigDone(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest rewording this to make it clear that this is not yet available in 2.4.2. E.g. "starting from 2.5.0, ...".