8000 Keep sock original timeout, If read,write timeout not set by iamdrq · Pull Request #868 · encode/httpcore · GitHub
[go: up one dir, main page]
Skip to content
/ httpcore Public

Keep sock original timeout, If read,write timeout not set #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into 8000
base: master
Choose a base branch
from
Open

Keep sock original timeout, If read,write timeout not set #868

wants to merge 1 commit into from

Conversation

iamdrq
Copy link
@iamdrq iamdrq commented Jan 5, 2024

Summary

In httpcore/_backends/sync.py, when not set timeout. It will override original sock timeout setting,this patch fixed it.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@iamdrq iamdrq mentioned this pull request Jan 8, 2024
Open
@stale Stale
Copy link
stale bot commented Apr 26, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iamdrq
0