8000 Socks proxy should support read/write timeouts · Issue #862 · encode/httpcore · GitHub
[go: up one dir, main page]
Skip to content

Socks proxy should support read/write timeouts #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Anthonybelui opened this issue Dec 22, 2023 Discussed in #859 · 2 comments
Open

Socks proxy should support read/write timeouts #862

Anthonybelui opened this issue Dec 22, 2023 Discussed in #859 · 2 comments
Labels
wontfix This will not be worked on

Comments

@Anthonybelui
Copy link

Discussed in #859

Originally posted by Anthonybelui December 16, 2023
Hello, thanks for developing the library.
I wanted to ask you to fix/define the logic for the read timeout in socks_proxy. This creates an infinity reading.

File httpcore/_sync/socks_proxy.py
Function _init_socks5_connection()
Line: incoming_bytes = stream.read(max_bytes=4096) > incoming_bytes = stream.read(max_bytes=4096, timeout=SomeTimeout)
@iamdrq
Copy link
iamdrq commented Jan 8, 2024

I opened a PR fixed this:
#868

@stale Stale
Copy link
stale bot commented Apr 26, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iamdrq @Anthonybelui
0